Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(14)

Side by Side Diff: content/shell/browser/shell_android.cc

Issue 616263002: Log "title" in PlatformSetTitle(). (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2013 The Chromium Authors. All rights reserved. 1 // Copyright 2013 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "content/shell/browser/shell.h" 5 #include "content/shell/browser/shell.h"
6 6
7 #include <jni.h> 7 #include <jni.h>
8 8
9 #include "base/android/jni_string.h" 9 #include "base/android/jni_string.h"
10 #include "base/android/scoped_java_ref.h" 10 #include "base/android/scoped_java_ref.h"
(...skipping 48 matching lines...) Expand 10 before | Expand all | Expand 10 after
59 JNIEnv* env = AttachCurrentThread(); 59 JNIEnv* env = AttachCurrentThread();
60 Java_Shell_initFromNativeTabContents( 60 Java_Shell_initFromNativeTabContents(
61 env, java_object_.obj(), reinterpret_cast<intptr_t>(web_contents())); 61 env, java_object_.obj(), reinterpret_cast<intptr_t>(web_contents()));
62 } 62 }
63 63
64 void Shell::PlatformResizeSubViews() { 64 void Shell::PlatformResizeSubViews() {
65 // Not needed; subviews are bound. 65 // Not needed; subviews are bound.
66 } 66 }
67 67
68 void Shell::PlatformSetTitle(const base::string16& title) { 68 void Shell::PlatformSetTitle(const base::string16& title) {
69 NOTIMPLEMENTED(); 69 NOTIMPLEMENTED() << ": " << title;
70 } 70 }
71 71
72 void Shell::LoadProgressChanged(WebContents* source, double progress) { 72 void Shell::LoadProgressChanged(WebContents* source, double progress) {
73 JNIEnv* env = AttachCurrentThread(); 73 JNIEnv* env = AttachCurrentThread();
74 Java_Shell_onLoadProgressChanged(env, java_object_.obj(), progress); 74 Java_Shell_onLoadProgressChanged(env, java_object_.obj(), progress);
75 } 75 }
76 76
77 void Shell::PlatformToggleFullscreenModeForTab(WebContents* web_contents, 77 void Shell::PlatformToggleFullscreenModeForTab(WebContents* web_contents,
78 bool enter_fullscreen) { 78 bool enter_fullscreen) {
79 JNIEnv* env = AttachCurrentThread(); 79 JNIEnv* env = AttachCurrentThread();
(...skipping 22 matching lines...) Expand all
102 return RegisterNativesImpl(env); 102 return RegisterNativesImpl(env);
103 } 103 }
104 104
105 // static 105 // static
106 void CloseShell(JNIEnv* env, jclass clazz, jlong shellPtr) { 106 void CloseShell(JNIEnv* env, jclass clazz, jlong shellPtr) {
107 Shell* shell = reinterpret_cast<Shell*>(shellPtr); 107 Shell* shell = reinterpret_cast<Shell*>(shellPtr);
108 shell->Close(); 108 shell->Close();
109 } 109 }
110 110
111 } // namespace content 111 } // namespace content
OLDNEW
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698