Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(237)

Issue 61623006: Revert 233460 "Prefer opening PDF downloads in the browser." (Closed)

Created:
7 years, 1 month ago by hashimoto
Modified:
7 years, 1 month ago
Reviewers:
asanka
CC:
chromium-reviews
Visibility:
Public.

Description

Revert 233460 "Prefer opening PDF downloads in the browser." Caused "PluginPrefsTest.UnifiedPepperFlashState" failure on "Linux Clang (dbg)" BUG=316017 > Prefer opening PDF downloads in the browser. > > PDFs in particular are safer to open in the browser. This patch changes > the handling of downloads to open such files in the browser by default > instead of the system handler for the file type. A "Open with system > handler" menu item will be available so that users can still use the > system application if needed. > > The determination that a file is safer to handle in the browser is done > as follows: > > a) DownloadTargetDeterminer determines whether the MIME type > corresponding to the target filename of the download is one which is > handled by the renderer or one that is handled by a sandboxed pepper > plugin. If so, then the file is considered safely handled by the > browser. > > b) ChromeDownloadManagerDelegate determines whether opening in the > browser is preferred for the file type assuming the browser is able > to handle it safely. Currently this is true for .pdf files. > > Opening behavior for a download will default to opening in the browser > if both results from a) and b) are true. > > BUG=148492 > > TEST=(1) Make sure Chrome PDF Viewer is enabled in chrome://plugins. > (2) Download a .pdf file. > (3) Download shelf context menu should show "Open" and "Open with > system handler" options. > (4) "Open" as well as clicking on the shelf icon and clicking on > the download in chrome://downloads should all result in opening > the file within the browser. > (5) "Open with system handler" should open the .pdf with the > application that's set up as the default handler for .pdf files > on the users' machine. > > Review URL: https://codereview.chromium.org/55063002 TBR=asanka@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=233497

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+130 lines, -920 lines) Patch
M trunk/src/chrome/browser/download/chrome_download_manager_delegate.h View 4 chunks +0 lines, -14 lines 0 comments Download
M trunk/src/chrome/browser/download/chrome_download_manager_delegate.cc View 8 chunks +7 lines, -99 lines 0 comments Download
M trunk/src/chrome/browser/download/chrome_download_manager_delegate_unittest.cc View 9 chunks +36 lines, -23 lines 0 comments Download
M trunk/src/chrome/browser/download/download_item_model.h View 1 chunk +0 lines, -12 lines 0 comments Download
M trunk/src/chrome/browser/download/download_item_model.cc View 6 chunks +1 line, -42 lines 0 comments Download
M trunk/src/chrome/browser/download/download_shelf_context_menu.h View 1 chunk +0 lines, -1 line 0 comments Download
M trunk/src/chrome/browser/download/download_shelf_context_menu.cc View 4 chunks +0 lines, -9 lines 0 comments Download
M trunk/src/chrome/browser/download/download_stats.h View 2 chunks +0 lines, -20 lines 0 comments Download
M trunk/src/chrome/browser/download/download_stats.cc View 1 chunk +0 lines, -6 lines 0 comments Download
M trunk/src/chrome/browser/download/download_target_determiner.h View 7 chunks +9 lines, -43 lines 0 comments Download
M trunk/src/chrome/browser/download/download_target_determiner.cc View 9 chunks +16 lines, -159 lines 0 comments Download
M trunk/src/chrome/browser/download/download_target_determiner_delegate.h View 2 chunks +0 lines, -8 lines 0 comments Download
M trunk/src/chrome/browser/download/download_target_determiner_unittest.cc View 14 chunks +61 lines, -422 lines 0 comments Download
D trunk/src/chrome/browser/download/download_target_info.h View 1 chunk +0 lines, -47 lines 0 comments Download
M trunk/src/chrome/chrome_browser.gypi View 1 chunk +0 lines, -1 line 0 comments Download
M trunk/src/tools/metrics/histograms/histograms.xml View 2 chunks +0 lines, -14 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
hashimoto
7 years, 1 month ago (2013-11-07 06:13:38 UTC) #1
hashimoto
7 years, 1 month ago (2013-11-07 06:13:59 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 manually as r233497.

Powered by Google App Engine
This is Rietveld 408576698