Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(366)

Unified Diff: trunk/src/chrome/browser/download/chrome_download_manager_delegate.h

Issue 61623006: Revert 233460 "Prefer opening PDF downloads in the browser." (Closed) Base URL: svn://svn.chromium.org/chrome/
Patch Set: Created 7 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | trunk/src/chrome/browser/download/chrome_download_manager_delegate.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: trunk/src/chrome/browser/download/chrome_download_manager_delegate.h
===================================================================
--- trunk/src/chrome/browser/download/chrome_download_manager_delegate.h (revision 233496)
+++ trunk/src/chrome/browser/download/chrome_download_manager_delegate.h (working copy)
@@ -11,7 +11,6 @@
#include "base/memory/scoped_ptr.h"
#include "chrome/browser/download/download_path_reservation_tracker.h"
#include "chrome/browser/download/download_target_determiner_delegate.h"
-#include "chrome/browser/download/download_target_info.h"
#include "chrome/browser/safe_browsing/download_protection_service.h"
#include "content/public/browser/download_danger_type.h"
#include "content/public/browser/download_item.h"
@@ -96,11 +95,6 @@
const content::CheckForFileExistenceCallback& callback) OVERRIDE;
virtual std::string ApplicationClientIdForFileScanning() const OVERRIDE;
- // Opens a download using the platform handler. DownloadItem::OpenDownload,
- // which ends up being handled by OpenDownload(), will open a download in the
- // browser if doing so is preferred.
- void OpenDownloadUsingPlatformHandler(content::DownloadItem* download);
-
DownloadPrefs* download_prefs() { return download_prefs_.get(); }
protected:
@@ -137,9 +131,6 @@
content::DownloadItem* download,
const base::FilePath& suggested_virtual_path,
const CheckDownloadUrlCallback& callback) OVERRIDE;
- virtual void GetFileMimeType(
- const base::FilePath& path,
- const GetFileMimeTypeCallback& callback) OVERRIDE;
private:
friend class base::RefCountedThreadSafe<ChromeDownloadManagerDelegate>;
@@ -166,11 +157,6 @@
void ReturnNextId(const content::DownloadIdCallback& callback);
- void OnDownloadTargetDetermined(
- int32 download_id,
- const content::DownloadTargetCallback& callback,
- scoped_ptr<DownloadTargetInfo> target_info);
-
Profile* profile_;
uint32 next_download_id_;
IdCallbackVector id_callbacks_;
« no previous file with comments | « no previous file | trunk/src/chrome/browser/download/chrome_download_manager_delegate.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698