Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(54)

Issue 616163002: Revert of Ensure that the browser’s copy of page id is in sync with the renderer’s. (Closed)

Created:
6 years, 2 months ago by Charlie Reis
Modified:
6 years, 2 months ago
CC:
chromium-reviews, darin-cc_chromium.org, nasko+codewatch_chromium.org, jam, creis+watch_chromium.org, site-isolation-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Revert of Ensure that the browser’s copy of page id is in sync with the renderer’s. (patchset #3 id:40001 of https://codereview.chromium.org/609943002/) Reason for revert: Crash data coming in, in version 40.0.2174.0. See http://crbug.com/419129 for details. Original issue's description: > Ensure that the browser’s copy of page id is in sync with the renderer’s. > > This is likely to crash, and so has debugging statements. > > BUG=407376 > TEST=no crashing, we hope > > Committed: https://crrev.com/af3e9e0b1325f0f4aaaf784c1379ffa34a20c31e > Cr-Commit-Position: refs/heads/master@{#297263} TBR=rsesek@chromium.org,avi@chromium.org NOTREECHECKS=true NOTRY=true BUG=407376 Committed: https://crrev.com/c619607dd99bfdeda399ef91e748e10629a60032 Cr-Commit-Position: refs/heads/master@{#297512}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -46 lines) Patch
M chrome/common/crash_keys.cc View 1 chunk +0 lines, -7 lines 0 comments Download
M content/browser/frame_host/render_frame_host_impl.cc View 1 chunk +0 lines, -1 line 0 comments Download
M content/browser/renderer_host/render_view_host_delegate.h View 1 chunk +0 lines, -1 line 0 comments Download
M content/browser/renderer_host/render_view_host_impl.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/web_contents/web_contents_impl.h View 1 chunk +0 lines, -1 line 0 comments Download
M content/browser/web_contents/web_contents_impl.cc View 2 chunks +0 lines, -35 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
Charlie Reis
Created Revert of Ensure that the browser’s copy of page id is in sync with ...
6 years, 2 months ago (2014-09-30 21:45:58 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/616163002/1
6 years, 2 months ago (2014-09-30 21:47:44 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1) as 971c52b3afb80a14f0c82a732a6e54a7021197b8
6 years, 2 months ago (2014-09-30 21:49:04 UTC) #3
commit-bot: I haz the power
6 years, 2 months ago (2014-09-30 21:50:56 UTC) #4
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/c619607dd99bfdeda399ef91e748e10629a60032
Cr-Commit-Position: refs/heads/master@{#297512}

Powered by Google App Engine
This is Rietveld 408576698