Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(513)

Side by Side Diff: chrome/common/crash_keys.cc

Issue 616163002: Revert of Ensure that the browser’s copy of page id is in sync with the renderer’s. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | content/browser/frame_host/render_frame_host_impl.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2013 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2013 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/common/crash_keys.h" 5 #include "chrome/common/crash_keys.h"
6 6
7 #include "base/command_line.h" 7 #include "base/command_line.h"
8 #include "base/format_macros.h" 8 #include "base/format_macros.h"
9 #include "base/logging.h" 9 #include "base/logging.h"
10 #include "base/strings/string_split.h" 10 #include "base/strings/string_split.h"
(...skipping 148 matching lines...) Expand 10 before | Expand all | Expand 10 after
159 { mac::kLastNSExceptionTrace, kMediumSize }, 159 { mac::kLastNSExceptionTrace, kMediumSize },
160 { mac::kNSException, kMediumSize }, 160 { mac::kNSException, kMediumSize },
161 { mac::kNSExceptionTrace, kMediumSize }, 161 { mac::kNSExceptionTrace, kMediumSize },
162 { mac::kSendAction, kMediumSize }, 162 { mac::kSendAction, kMediumSize },
163 { mac::kZombie, kMediumSize }, 163 { mac::kZombie, kMediumSize },
164 { mac::kZombieTrace, kMediumSize }, 164 { mac::kZombieTrace, kMediumSize },
165 // content/: 165 // content/:
166 { "channel_error_bt", kMediumSize }, 166 { "channel_error_bt", kMediumSize },
167 { "remove_route_bt", kMediumSize }, 167 { "remove_route_bt", kMediumSize },
168 { "rwhvm_window", kMediumSize }, 168 { "rwhvm_window", kMediumSize },
169 // The following keys are for diagnosing crashes in http://crbug.com/369661.
170 // They will not be permanent.
171 { "renderer_page_id", kSmallSize },
172 { "browser_page_id", kSmallSize },
173 { "last_committed_page_id", kSmallSize },
174 { "quick_discard", kSmallSize },
175 // End http://crbug.com/369661
176 // media/: 169 // media/:
177 { "VideoCaptureDeviceQTKit", kSmallSize }, 170 { "VideoCaptureDeviceQTKit", kSmallSize },
178 #endif 171 #endif
179 }; 172 };
180 173
181 // This dynamic set of keys is used for sets of key value pairs when gathering 174 // This dynamic set of keys is used for sets of key value pairs when gathering
182 // a collection of data, like command line switches or extension IDs. 175 // a collection of data, like command line switches or extension IDs.
183 std::vector<base::debug::CrashKey> keys( 176 std::vector<base::debug::CrashKey> keys(
184 fixed_keys, fixed_keys + arraysize(fixed_keys)); 177 fixed_keys, fixed_keys + arraysize(fixed_keys));
185 178
(...skipping 216 matching lines...) Expand 10 before | Expand all | Expand 10 after
402 } 395 }
403 396
404 ScopedPrinterInfo::~ScopedPrinterInfo() { 397 ScopedPrinterInfo::~ScopedPrinterInfo() {
405 for (size_t i = 0; i < kPrinterInfoCount; ++i) { 398 for (size_t i = 0; i < kPrinterInfoCount; ++i) {
406 std::string key = base::StringPrintf(kPrinterInfo, i + 1); 399 std::string key = base::StringPrintf(kPrinterInfo, i + 1);
407 base::debug::ClearCrashKey(key); 400 base::debug::ClearCrashKey(key);
408 } 401 }
409 } 402 }
410 403
411 } // namespace crash_keys 404 } // namespace crash_keys
OLDNEW
« no previous file with comments | « no previous file | content/browser/frame_host/render_frame_host_impl.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698