Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(30)

Issue 616143002: Don't close SRT bubble on deactivate. (Closed)

Created:
6 years, 2 months ago by MAD
Modified:
6 years, 2 months ago
Reviewers:
csharp, noelutz
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Don't close SRT bubble on deactivate. TBR=noelutz OWNER of chrome/browser/safe_browsing folder, for trivial change of returning false instead of base class' true. Being exercised already by other derived classes, e.g., ExtensionDisabledGlobalError We will want to merge this to M39 once it gets added to Canary, hopefully tomorrow... BUG=419049 Committed: https://crrev.com/8e22478d67a6f705d7bb2f66142f05f780e99e94 Cr-Commit-Position: refs/heads/master@{#297518}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -0 lines) Patch
M chrome/browser/safe_browsing/srt_global_error_win.h View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/safe_browsing/srt_global_error_win.cc View 1 chunk +4 lines, -0 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
MAD
6 years, 2 months ago (2014-09-30 20:21:45 UTC) #2
csharp
lgtm
6 years, 2 months ago (2014-09-30 20:27:09 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/616143002/1
6 years, 2 months ago (2014-09-30 20:30:02 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1) as 46c4346d53c4b8344b93232c440fcafd1edb3560
6 years, 2 months ago (2014-09-30 22:08:16 UTC) #6
commit-bot: I haz the power
6 years, 2 months ago (2014-09-30 22:11:03 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/8e22478d67a6f705d7bb2f66142f05f780e99e94
Cr-Commit-Position: refs/heads/master@{#297518}

Powered by Google App Engine
This is Rietveld 408576698