Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(161)

Side by Side Diff: chrome/browser/safe_browsing/srt_global_error_win.cc

Issue 616143002: Don't close SRT bubble on deactivate. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « chrome/browser/safe_browsing/srt_global_error_win.h ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2014 The Chromium Authors. All rights reserved. 1 // Copyright 2014 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/browser/safe_browsing/srt_global_error_win.h" 5 #include "chrome/browser/safe_browsing/srt_global_error_win.h"
6 6
7 #include "base/callback.h" 7 #include "base/callback.h"
8 #include "base/metrics/histogram.h" 8 #include "base/metrics/histogram.h"
9 #include "chrome/app/chrome_command_ids.h" 9 #include "chrome/app/chrome_command_ids.h"
10 #include "chrome/browser/ui/browser.h" 10 #include "chrome/browser/ui/browser.h"
(...skipping 89 matching lines...) Expand 10 before | Expand all | Expand 10 after
100 ui::PAGE_TRANSITION_LINK, 100 ui::PAGE_TRANSITION_LINK,
101 false)); 101 false));
102 DismissGlobalError(); 102 DismissGlobalError();
103 } 103 }
104 104
105 void SRTGlobalError::BubbleViewCancelButtonPressed(Browser* browser) { 105 void SRTGlobalError::BubbleViewCancelButtonPressed(Browser* browser) {
106 RecordSRTPromptHistogram(SRT_PROMPT_DENIED); 106 RecordSRTPromptHistogram(SRT_PROMPT_DENIED);
107 DismissGlobalError(); 107 DismissGlobalError();
108 } 108 }
109 109
110 bool SRTGlobalError::ShouldCloseOnDeactivate() const {
111 return false;
112 }
113
110 void SRTGlobalError::DismissGlobalError() { 114 void SRTGlobalError::DismissGlobalError() {
111 global_error_service_->RemoveGlobalError(this); 115 global_error_service_->RemoveGlobalError(this);
112 delete this; 116 delete this;
113 } 117 }
OLDNEW
« no previous file with comments | « chrome/browser/safe_browsing/srt_global_error_win.h ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698