Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(431)

Unified Diff: content/browser/frame_host/render_frame_host_manager.h

Issue 616133002: Make RenderFrame(Host) own a RenderWidget(Host). (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: git cl format, changed WebWidget creation Created 6 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/frame_host/render_frame_host_manager.h
diff --git a/content/browser/frame_host/render_frame_host_manager.h b/content/browser/frame_host/render_frame_host_manager.h
index 4d60c0eede89664e8fea23bf2c2b9975e2991c95..24f2309015859a2ce3863dae3e9ccec4ae737b36 100644
--- a/content/browser/frame_host/render_frame_host_manager.h
+++ b/content/browser/frame_host/render_frame_host_manager.h
@@ -458,8 +458,10 @@ class CONTENT_EXPORT RenderFrameHostManager : public NotificationObserver {
// we are staying in the same BrowsingInstance. This allows the new RFH
// to send cross-process script calls to its opener(s). Returns the opener
// route ID to be used for the new RenderView to be created.
+ // |create_render_frame_flags| allows the method to set additional flags.
int CreateOpenerRenderViewsIfNeeded(SiteInstance* old_instance,
- SiteInstance* new_instance);
+ SiteInstance* new_instance,
+ int& create_render_frame_flags);
nasko 2014/12/17 22:51:30 Int is small enough that it should be passed by va
kenrb 2015/01/05 21:15:30 The argument is there so the method can optionally
Charlie Reis 2015/01/06 00:04:57 Shouldn't that be an int*?
kenrb 2015/01/06 17:39:04 Yes. int& is Blink coding style. :(
// Creates a RenderFrameHost and corresponding RenderViewHost if necessary.
scoped_ptr<RenderFrameHostImpl> CreateRenderFrameHost(SiteInstance* instance,

Powered by Google App Engine
This is Rietveld 408576698