Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(19)

Side by Side Diff: content/browser/frame_host/render_frame_host_manager.h

Issue 616133002: Make RenderFrame(Host) own a RenderWidget(Host). (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: git cl format, changed WebWidget creation Created 6 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2013 The Chromium Authors. All rights reserved. 1 // Copyright 2013 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef CONTENT_BROWSER_FRAME_HOST_RENDER_FRAME_HOST_MANAGER_H_ 5 #ifndef CONTENT_BROWSER_FRAME_HOST_RENDER_FRAME_HOST_MANAGER_H_
6 #define CONTENT_BROWSER_FRAME_HOST_RENDER_FRAME_HOST_MANAGER_H_ 6 #define CONTENT_BROWSER_FRAME_HOST_RENDER_FRAME_HOST_MANAGER_H_
7 7
8 #include <list> 8 #include <list>
9 9
10 #include "base/basictypes.h" 10 #include "base/basictypes.h"
(...skipping 440 matching lines...) Expand 10 before | Expand all | Expand 10 after
451 // |pending_render_frame_host_| while respecting the opener route if needed 451 // |pending_render_frame_host_| while respecting the opener route if needed
452 // and stores it in pending_render_frame_host_. 452 // and stores it in pending_render_frame_host_.
453 void CreatePendingRenderFrameHost(SiteInstance* old_instance, 453 void CreatePendingRenderFrameHost(SiteInstance* old_instance,
454 SiteInstance* new_instance, 454 SiteInstance* new_instance,
455 bool is_main_frame); 455 bool is_main_frame);
456 456
457 // Ensure that we have created RFHs for the new RFH's opener chain if 457 // Ensure that we have created RFHs for the new RFH's opener chain if
458 // we are staying in the same BrowsingInstance. This allows the new RFH 458 // we are staying in the same BrowsingInstance. This allows the new RFH
459 // to send cross-process script calls to its opener(s). Returns the opener 459 // to send cross-process script calls to its opener(s). Returns the opener
460 // route ID to be used for the new RenderView to be created. 460 // route ID to be used for the new RenderView to be created.
461 // |create_render_frame_flags| allows the method to set additional flags.
461 int CreateOpenerRenderViewsIfNeeded(SiteInstance* old_instance, 462 int CreateOpenerRenderViewsIfNeeded(SiteInstance* old_instance,
462 SiteInstance* new_instance); 463 SiteInstance* new_instance,
464 int& create_render_frame_flags);
nasko 2014/12/17 22:51:30 Int is small enough that it should be passed by va
kenrb 2015/01/05 21:15:30 The argument is there so the method can optionally
Charlie Reis 2015/01/06 00:04:57 Shouldn't that be an int*?
kenrb 2015/01/06 17:39:04 Yes. int& is Blink coding style. :(
463 465
464 // Creates a RenderFrameHost and corresponding RenderViewHost if necessary. 466 // Creates a RenderFrameHost and corresponding RenderViewHost if necessary.
465 scoped_ptr<RenderFrameHostImpl> CreateRenderFrameHost(SiteInstance* instance, 467 scoped_ptr<RenderFrameHostImpl> CreateRenderFrameHost(SiteInstance* instance,
466 int view_routing_id, 468 int view_routing_id,
467 int frame_routing_id, 469 int frame_routing_id,
468 int flags); 470 int flags);
469 471
470 // Sets up the necessary state for a new RenderViewHost with the given opener, 472 // Sets up the necessary state for a new RenderViewHost with the given opener,
471 // if necessary. It creates a RenderFrameProxy in the target renderer process 473 // if necessary. It creates a RenderFrameProxy in the target renderer process
472 // with the given |proxy_routing_id|, which is used to route IPC messages when 474 // with the given |proxy_routing_id|, which is used to route IPC messages when
(...skipping 129 matching lines...) Expand 10 before | Expand all | Expand 10 after
602 NotificationRegistrar registrar_; 604 NotificationRegistrar registrar_;
603 605
604 base::WeakPtrFactory<RenderFrameHostManager> weak_factory_; 606 base::WeakPtrFactory<RenderFrameHostManager> weak_factory_;
605 607
606 DISALLOW_COPY_AND_ASSIGN(RenderFrameHostManager); 608 DISALLOW_COPY_AND_ASSIGN(RenderFrameHostManager);
607 }; 609 };
608 610
609 } // namespace content 611 } // namespace content
610 612
611 #endif // CONTENT_BROWSER_FRAME_HOST_RENDER_FRAME_HOST_MANAGER_H_ 613 #endif // CONTENT_BROWSER_FRAME_HOST_RENDER_FRAME_HOST_MANAGER_H_
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698