Remove Scrollbar dependency on Frame, FrameView and EventHandler

Remove Scrollbar dependency on Frame, FrameView and EventHandler

There is no need to set m_mousePressed from Scrollbar::mouseUp as
EventHandler::handleMouseReleaseEvent did that before calling mouseUp.
The other two callers of mouseUp involve scrollbars that are not in FrameViews.

BUG=297477
Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=161628

[Stephen Chennney, 2013-11-07 19:57:37]

I'm not real confident about this one. I think it's OK, but I would like a
second opinion. So over to Adam (or someone Adam thinks would be good).

[rwlbuis, 2013-11-07 19:59:30]

On 2013/11/07 19:57:37, Stephen Chenney wrote:
> I'm not real confident about this one. I think it's OK, but I would like a
> second opinion. So over to Adam (or someone Adam thinks would be good).

Sure!
For reference, there is a similar WebKit patch
https://bugs.webkit.org/show_bug.cgi?id=114941

[eseidel, 2013-11-08 10:28:30]

I think all the work to move Widget and friends down to Platform is a bit
sketchy.  We should just kill the Widget concept. :)

That said, I don't want to stand in the way of progress...

https://codereview.chromium.org/61603003/diff/70001/Source/core/platform/Scro...
File Source/core/platform/Scrollbar.cpp (left):

https://codereview.chromium.org/61603003/diff/70001/Source/core/platform/Scro...
Source/core/platform/Scrollbar.cpp:462:
toFrameView(parent())->frame().eventHandler().setMousePressed(false);
Why is it OK to remove this?

[eseidel, 2013-11-08 10:28:50]

lgtm

OK.

[commit-bot: I haz the power, 2013-11-08 11:32:56]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/rob.buis@samsung.com/61603003/70001

[commit-bot: I haz the power, 2013-11-08 11:32:59]

Failed to apply patch for Source/core/platform/Scrollbar.cpp:
While running patch -p1 --forward --force --no-backup-if-mismatch;
  patching file Source/core/platform/Scrollbar.cpp
  Hunk #1 FAILED at 28.
  Hunk #2 succeeded at 131 (offset -4 lines).
  Hunk #3 succeeded at 453 (offset -4 lines).
  1 out of 3 hunks FAILED -- saving rejects to file
Source/core/platform/Scrollbar.cpp.rej

Patch:       Source/core/platform/Scrollbar.cpp
Index: Source/core/platform/Scrollbar.cpp
diff --git a/Source/core/platform/Scrollbar.cpp
b/Source/core/platform/Scrollbar.cpp
index
a5fd76f2a5861dced72a39e7ef94fa3ce4260158..201a7d255fa1b9f1424b47f9caf08874dd01527b
100644
--- a/Source/core/platform/Scrollbar.cpp
+++ b/Source/core/platform/Scrollbar.cpp
@@ -28,16 +28,11 @@
 
 #include <algorithm>
 #include "core/platform/ScrollAnimator.h"
+#include "core/platform/ScrollView.h"
 #include "core/platform/ScrollableArea.h"
 #include "core/platform/ScrollbarTheme.h"
 #include "core/platform/graphics/GraphicsContext.h"
 
-// FIXME: The following #includes are a layering violation and should be
removed.
-#include "core/accessibility/AXObjectCache.h"
-#include "core/page/EventHandler.h"
-#include "core/frame/Frame.h"
-#include "core/frame/FrameView.h"
-
 #include "platform/PlatformGestureEvent.h"
 #include "platform/PlatformMouseEvent.h"
 
@@ -135,7 +130,7 @@ bool Scrollbar::isScrollableAreaActive() const
 
 bool Scrollbar::isScrollViewScrollbar() const
 {
-    return parent() && parent()->isFrameView() &&
toFrameView(parent())->isScrollViewScrollbar(this);
+    return parent() && parent()->isFrameView() &&
toScrollView(parent())->isScrollViewScrollbar(this);
 }
 
 bool Scrollbar::isLeftSideVerticalScrollbar() const
@@ -457,9 +452,6 @@ void Scrollbar::mouseUp(const PlatformMouseEvent&
mouseEvent)
         if (part == NoPart)
             m_scrollableArea->mouseExitedScrollbar(this);
     }
-
-    if (parent() && parent()->isFrameView())
-        toFrameView(parent())->frame().eventHandler().setMousePressed(false);
 }
 
 void Scrollbar::mouseDown(const PlatformMouseEvent& evt)

[commit-bot: I haz the power, 2013-11-08 14:01:56]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/rob.buis@samsung.com/61603003/130001

[commit-bot: I haz the power, 2013-11-08 15:37:21]

Change committed as 161628