Remove Scrollbar dependency on Frame, FrameView and EventHandler

Source/core/platform/Scrollbar.cpp

 /*
  * Copyright (C) 2004, 2006, 2008 Apple Inc. All rights reserved.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions
  * are met:
  * 1. Redistributions of source code must retain the above copyright
  *    notice, this list of conditions and the following disclaimer.
  * 2. Redistributions in binary form must reproduce the above copyright
  *    notice, this list of conditions and the following disclaimer in the
@@ skipping 10 matching lines @@
  * OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT
  * (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE
  * OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
  */
 
 #include "config.h"
 #include "core/platform/Scrollbar.h"
 
 #include <algorithm>
 #include "core/platform/ScrollAnimator.h"
+#include "core/platform/ScrollView.h"
 #include "core/platform/ScrollableArea.h"
 #include "core/platform/ScrollbarTheme.h"
 #include "core/platform/graphics/GraphicsContext.h"
 
-// FIXME: The following #includes are a layering violation and should be removed.
-#include "core/accessibility/AXObjectCache.h"
-#include "core/page/EventHandler.h"
-#include "core/frame/Frame.h"
-#include "core/frame/FrameView.h"
-
 #include "platform/PlatformGestureEvent.h"
 #include "platform/PlatformMouseEvent.h"
 
 using namespace std;
 
 #if OS(POSIX) && !OS(MACOSX)
 // The position of the scrollbar thumb affects the appearance of the steppers, so
 // when the thumb moves, we have to invalidate them for painting.
 #define THUMB_POSITION_AFFECTS_BUTTONS
 #endif
@@ skipping 77 matching lines @@
         m_scrollableArea->getTickmarks(tickmarks);
 }
 
 bool Scrollbar::isScrollableAreaActive() const
 {
     return m_scrollableArea && m_scrollableArea->isActive();
 }
 
 bool Scrollbar::isScrollViewScrollbar() const
 {
-    return parent() && parent()->isFrameView() && toFrameView(parent())->isScrollViewScrollbar(this);
+    return parent() && parent()->isFrameView() && toScrollView(parent())->isScrollViewScrollbar(this);
 }
 
 bool Scrollbar::isLeftSideVerticalScrollbar() const
 {
     if (m_orientation == VerticalScrollbar && m_scrollableArea)
         return m_scrollableArea->shouldPlaceVerticalScrollbarOnLeft();
     return false;
 }
 
 void Scrollbar::offsetDidChange()
@@ skipping 301 matching lines @@
     m_draggingDocument = false;
     stopTimerIfNeeded();
 
     if (m_scrollableArea) {
         // m_hoveredPart won't be updated until the next mouseMoved or mouseDown, so we have to hit test
         // to really know if the mouse has exited the scrollbar on a mouseUp.
         ScrollbarPart part = theme()->hitTest(this, mouseEvent.position());
         if (part == NoPart)
             m_scrollableArea->mouseExitedScrollbar(this);
     }
-
-    if (parent() && parent()->isFrameView())
-        toFrameView(parent())->frame().eventHandler().setMousePressed(false);

[eseidel, 2013/11/08 10:28:31]

Why is it OK to remove this?

 }
 
 void Scrollbar::mouseDown(const PlatformMouseEvent& evt)
 {
     // Early exit for right click
     if (evt.button() == RightButton)
         return;
 
     setPressedPart(theme()->hitTest(this, evt.position()));
     int pressedPos = (orientation() == HorizontalScrollbar ? convertFromContainingWindow(evt.position()).x() : convertFromContainingWindow(evt.position()).y());
@@ skipping 139 matching lines @@
     if (!m_scrollableArea)
         return 0;
 
     if (m_orientation == HorizontalScrollbar)
         return m_scrollableArea->scrollPosition().x() - m_scrollableArea->minimumScrollPosition().x();
 
     return m_scrollableArea->scrollPosition().y() - m_scrollableArea->minimumScrollPosition().y();
 }
 
 } // namespace WebCore