extensions/browser/api/execute_code_function.cc - Issue 615703002: Verify that ComponentExtensionResourceManager exists before using it.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: extensions/browser/api/execute_code_function.cc

Issue 615703002: Verify that ComponentExtensionResourceManager exists before using it. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 6 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: extensions/browser/api/execute_code_function.cc

diff --git a/extensions/browser/api/execute_code_function.cc b/extensions/browser/api/execute_code_function.cc

index 6df92b488f61c73ead15aa0ff200ca679745645f..219a6583746c301de7c808f1f1638e3c24070025 100644

--- a/extensions/browser/api/execute_code_function.cc

+++ b/extensions/browser/api/execute_code_function.cc

@@ -206,7 +206,8 @@ bool ExecuteCodeFunction::RunAsync() {

}

int resource_id;

- if (ExtensionsBrowserClient::Get()

+ if (ExtensionsBrowserClient::Get()->GetComponentExtensionResourceManager() &&

Ken Rockot(use gerrit already) 2014/09/29 21:56:32 nit: Retain the value of ExtensionsBrowserClient::

lfg 2014/09/29 22:12:44 Done.

+ ExtensionsBrowserClient::Get()

->GetComponentExtensionResourceManager()

->IsComponentExtensionResource(resource_.extension_root(),

resource_.relative_path(),

« no previous file with comments | « no previous file | no next file » | no next file with comments »