Verify that ComponentExtensionResourceManager exists before using it.

extensions/browser/api/execute_code_function.cc

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef EXTENSIONS_BROWSER_API_EXECUTE_CODE_FUNCTION_IMPL_H_
 #define EXTENSIONS_BROWSER_API_EXECUTE_CODE_FUNCTION_IMPL_H_
 
 #include "extensions/browser/api/execute_code_function.h"
 
 #include "extensions/browser/component_extension_resource_manager.h"
@@ skipping 188 matching lines @@
   if (!details_->file.get())
     return false;
   resource_ = extension()->GetResource(*details_->file);
 
   if (resource_.extension_root().empty() || resource_.relative_path().empty()) {
     error_ = kNoCodeOrFileToExecuteError;
     return false;
   }
 
   int resource_id;
-  if (ExtensionsBrowserClient::Get()
+  if (ExtensionsBrowserClient::Get()->GetComponentExtensionResourceManager() &&

[Ken Rockot(use gerrit already), 2014/09/29 21:56:32]

nit: Retain the value of
ExtensionsBrowserClient::Get()->GetComponentExtensionResourceManager() first and
then test (foo && foo->IsEtcEtc..) instead of this verbose expression.

[lfg, 2014/09/29 22:12:44]

Done.

+      ExtensionsBrowserClient::Get()
           ->GetComponentExtensionResourceManager()
           ->IsComponentExtensionResource(resource_.extension_root(),
                                          resource_.relative_path(),
                                          &resource_id)) {
     const ResourceBundle& rb = ResourceBundle::GetSharedInstance();
     DidLoadFile(true, rb.GetRawDataResource(resource_id).as_string());
   } else {
     scoped_refptr<FileReader> file_reader(new FileReader(
         resource_, base::Bind(&ExecuteCodeFunction::DidLoadFile, this)));
     file_reader->Start();
   }
 
   return true;
 }
 
 void ExecuteCodeFunction::OnExecuteCodeFinished(const std::string& error,
                                                 const GURL& on_url,
                                                 const base::ListValue& result) {
   if (!error.empty())
     SetError(error);
 
   SendResponse(error.empty());
 }
 
 }  // namespace extensions
 
 #endif  // EXTENSIONS_BROWSER_API_EXECUTE_CODE_FUNCTION_IMPL_H_