Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(30)

Issue 615703002: Verify that ComponentExtensionResourceManager exists before using it. (Closed)

Created:
6 years, 2 months ago by lfg
Modified:
6 years, 2 months ago
CC:
chromium-reviews, chromium-apps-reviews_chromium.org, extensions-reviews_chromium.org, lazyboy
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Verify that ComponentExtensionResourceManager exists before using it. App_shell doesn't have a ComponentExtensionResourceManager implementation, so we need to check if it's available before using it. BUG=352293 Committed: https://crrev.com/4f8f50d244424ca4fe8765e8727581bd8dbdb23e Cr-Commit-Position: refs/heads/master@{#297299}

Patch Set 1 #

Total comments: 2

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -5 lines) Patch
M extensions/browser/api/execute_code_function.cc View 1 1 chunk +7 lines, -5 lines 0 comments Download

Messages

Total messages: 10 (4 generated)
lfg
6 years, 2 months ago (2014-09-29 21:53:12 UTC) #2
Ken Rockot(use gerrit already)
lgtm https://codereview.chromium.org/615703002/diff/1/extensions/browser/api/execute_code_function.cc File extensions/browser/api/execute_code_function.cc (right): https://codereview.chromium.org/615703002/diff/1/extensions/browser/api/execute_code_function.cc#newcode209 extensions/browser/api/execute_code_function.cc:209: if (ExtensionsBrowserClient::Get()->GetComponentExtensionResourceManager() && nit: Retain the value of ...
6 years, 2 months ago (2014-09-29 21:56:33 UTC) #3
lfg
https://codereview.chromium.org/615703002/diff/1/extensions/browser/api/execute_code_function.cc File extensions/browser/api/execute_code_function.cc (right): https://codereview.chromium.org/615703002/diff/1/extensions/browser/api/execute_code_function.cc#newcode209 extensions/browser/api/execute_code_function.cc:209: if (ExtensionsBrowserClient::Get()->GetComponentExtensionResourceManager() && On 2014/09/29 21:56:32, Ken Rockot wrote: ...
6 years, 2 months ago (2014-09-29 22:12:44 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/615703002/20001
6 years, 2 months ago (2014-09-29 22:56:15 UTC) #8
commit-bot: I haz the power
Committed patchset #2 (id:20001) as f4a4b009bee9c5b6f02bd4f0a533be8aaccc5028
6 years, 2 months ago (2014-09-29 23:20:19 UTC) #9
commit-bot: I haz the power
6 years, 2 months ago (2014-09-29 23:21:42 UTC) #10
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/4f8f50d244424ca4fe8765e8727581bd8dbdb23e
Cr-Commit-Position: refs/heads/master@{#297299}

Powered by Google App Engine
This is Rietveld 408576698