Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(320)

Issue 615663002: Mac: Remove download shelf from AX hierarchy when not visible (Closed)

Created:
6 years, 2 months ago by Andre
Modified:
6 years, 2 months ago
Reviewers:
Avi (use Gerrit)
CC:
chromium-reviews, asanka, benjhayden+dwatch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Mac: Remove download shelf from AX hierarchy when not visible. When the download shelf is closed, it's still in the view hierarchy with height of 0. To make it not appear in the AX hierarchy, we hide the view after the close animation is finished. BUG=417698 Committed: https://crrev.com/d7d85e9d27acfb64033866553f9e590707a84530 Cr-Commit-Position: refs/heads/master@{#297300}

Patch Set 1 #

Patch Set 2 : Add unit test #

Unified diffs Side-by-side diffs Delta from patch set Stats (+44 lines, -3 lines) Patch
M chrome/browser/ui/cocoa/download/download_shelf_controller.mm View 2 chunks +7 lines, -3 lines 0 comments Download
M chrome/browser/ui/cocoa/download/download_shelf_controller_unittest.mm View 1 5 chunks +37 lines, -0 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
Andre
Avi, please review.
6 years, 2 months ago (2014-09-29 22:17:01 UTC) #2
Avi (use Gerrit)
lgtm
6 years, 2 months ago (2014-09-29 22:19:32 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/615663002/20001
6 years, 2 months ago (2014-09-29 22:22:22 UTC) #5
commit-bot: I haz the power
Committed patchset #2 (id:20001) as 12ad54eed5c69463eaad9ac01dfd91a1c9689b45
6 years, 2 months ago (2014-09-29 23:22:41 UTC) #6
commit-bot: I haz the power
6 years, 2 months ago (2014-09-29 23:23:33 UTC) #7
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/d7d85e9d27acfb64033866553f9e590707a84530
Cr-Commit-Position: refs/heads/master@{#297300}

Powered by Google App Engine
This is Rietveld 408576698