Mac: Remove download shelf from AX hierarchy when not visible

chrome/browser/ui/cocoa/download/download_shelf_controller_unittest.mm

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #import <Cocoa/Cocoa.h>
 
+#import "base/mac/scoped_block.h"
 #import "base/mac/scoped_nsobject.h"
 #include "base/memory/scoped_ptr.h"
 #include "chrome/browser/download/download_shelf.h"
 #include "chrome/browser/ui/cocoa/cocoa_profile_test.h"
 #import "chrome/browser/ui/cocoa/download/download_item_controller.h"
 #import "chrome/browser/ui/cocoa/download/download_shelf_controller.h"
 #import "chrome/browser/ui/cocoa/view_resizer_pong.h"
 #include "content/public/test/mock_download_item.h"
 #include "testing/gtest/include/gtest/gtest.h"
 #include "testing/platform_test.h"
@@ skipping 36 matching lines @@
 }
 - (WrappedMockDownloadItem*)wrappedMockDownload;
 @end
 
 @implementation DownloadItemController (DownloadShelfControllerTest)
 - (WrappedMockDownloadItem*)wrappedMockDownload {
   return nil;
 }
 @end
 
+@interface DownloadShelfController (Testing)
+- (void)animationDidEnd:(NSAnimation*)animation;
+@end
+
 // Subclass of the DownloadShelfController to override scheduleAutoClose and
 // cancelAutoClose. During regular operation, a scheduled autoClose waits for 5
 // seconds before closing the shelf (unless it is cancelled during this
 // time). For testing purposes, we count the number of invocations of
 // {schedule,cancel}AutoClose instead of actually scheduling and cancelling.
 @interface CountingDownloadShelfController : DownloadShelfController {
  @public
   int scheduleAutoCloseCount_;
   int cancelAutoCloseCount_;
+  base::mac::ScopedBlock<dispatch_block_t> closeAnimationHandler_;
 }
+
+// Handler will be called at the end of a close animation.
+- (void)setCloseAnimationHandler:(dispatch_block_t)handler;
 @end
 
 @implementation CountingDownloadShelfController
 
 -(void)scheduleAutoClose {
   ++scheduleAutoCloseCount_;
 }
 
 -(void)cancelAutoClose {
   ++cancelAutoCloseCount_;
 }
+
+- (void)setCloseAnimationHandler:(dispatch_block_t)handler {
+  closeAnimationHandler_.reset(handler);
+}
+
+- (void)animationDidEnd:(NSAnimation*)animation {
+  [super animationDidEnd:animation];
+  if (closeAnimationHandler_)
+    closeAnimationHandler_.get()();
+}
+
 @end
 
 namespace {
 
 class DownloadShelfControllerTest : public CocoaProfileTest {
  public:
   virtual void SetUp() OVERRIDE {
     CocoaProfileTest::SetUp();
     ASSERT_TRUE(browser());
 
@@ skipping 259 matching lines @@
   [shelf_ add:item.get()];
   EXPECT_EQ(0, shelf_.get()->scheduleAutoCloseCount_);
   EXPECT_EQ(2, shelf_.get()->cancelAutoCloseCount_);
 
   [shelf_ exiting];
   EXPECT_EQ(0, shelf_.get()->scheduleAutoCloseCount_);
   EXPECT_EQ(3, shelf_.get()->cancelAutoCloseCount_);
   shelf_.reset();
 }
 
+// The view should not be hidden when the shelf is shown.
+// The view should be hidden after the closing animation.
+TEST_F(DownloadShelfControllerTest, ViewVisibility) {
+  [shelf_ showDownloadShelf:YES isUserAction:NO];
+  EXPECT_FALSE([[shelf_ view] isHidden]);
+
+  [shelf_ setCloseAnimationHandler:^{
+      base::MessageLoop::current()->QuitNow();
+  }];
+  [shelf_ showDownloadShelf:NO isUserAction:NO];
+  base::MessageLoop::current()->Run();
+  EXPECT_TRUE([[shelf_ view] isHidden]);
+
+  [shelf_ showDownloadShelf:YES isUserAction:NO];
+  EXPECT_FALSE([[shelf_ view] isHidden]);
+}
+
 }  // namespace