Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(41)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 615583003: Introduce NetworkDelegate's implementation in extensions. (Closed)

Created:
6 years, 2 months ago by Xi Han
Modified:
6 years, 2 months ago
CC:
chromium-reviews, extensions-reviews_chromium.org, jam, darin-cc_chromium.org, chromium-apps-reviews_chromium.org, mkwst+moarreviews-shell_chromium.org, jochen+watch_chromium.org, lfg, wjmaclean
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

App_shell doesn't have similar implementation of ChromeExtensionsNetworkDelegateImpl to handle and route url request. In this CL, the ExtensionsNetworkDelegate is introduced as the same purpose. BUG=352293 Committed: https://crrev.com/d0f788b79f1c3b2e544be7b3e12326deb12bb34a Cr-Commit-Position: refs/heads/master@{#297959}

Patch Set 1 : #

Total comments: 3

Patch Set 2 : Reimplemente. #

Patch Set 3 : Add default behaviors in WebRequestEventRouterDelegate. #

Patch Set 4 : Move strings in shell_switches.h to //extensions/shell/common/switches.h. #

Patch Set 5 : Move strings to //extensions/common/switches.h #

Patch Set 6 : #

Total comments: 1

Patch Set 7 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+213 lines, -357 lines) Patch
M extensions/browser/BUILD.gn View 1 2 2 chunks +4 lines, -0 lines 0 comments Download
M extensions/browser/api/extensions_api_client.cc View 1 2 2 chunks +2 lines, -1 line 0 comments Download
M extensions/browser/api/web_request/web_request_event_router_delegate.h View 1 2 2 chunks +2 lines, -2 lines 0 comments Download
M extensions/browser/api/web_request/web_request_event_router_delegate.cc View 1 2 chunks +8 lines, -0 lines 0 comments Download
A + extensions/browser/extension_network_delegate.h View 1 2 chunks +19 lines, -28 lines 0 comments Download
A + extensions/browser/extension_network_delegate.cc View 1 2 3 4 4 chunks +32 lines, -256 lines 0 comments Download
A + extensions/browser/extension_url_request_context_getter.h View 1 2 chunks +23 lines, -22 lines 0 comments Download
A + extensions/browser/extension_url_request_context_getter.cc View 1 2 3 4 9 chunks +45 lines, -43 lines 0 comments Download
M extensions/common/switches.h View 1 2 3 4 1 chunk +1 line, -0 lines 0 comments Download
M extensions/common/switches.cc View 1 2 3 4 1 chunk +3 lines, -0 lines 0 comments Download
M extensions/extensions.gyp View 1 2 chunks +4 lines, -0 lines 0 comments Download
M extensions/shell/browser/shell_browser_context.h View 1 2 2 chunks +16 lines, -1 line 0 comments Download
M extensions/shell/browser/shell_browser_context.cc View 1 2 3 4 5 6 2 chunks +51 lines, -1 line 0 comments Download
M extensions/shell/browser/shell_browser_main_parts.cc View 1 2 3 4 5 2 chunks +2 lines, -1 line 0 comments Download
M extensions/shell/browser/shell_content_browser_client.cc View 1 1 chunk +1 line, -2 lines 0 comments Download

Messages

Total messages: 19 (10 generated)
Xi Han
6 years, 2 months ago (2014-09-29 19:05:15 UTC) #7
Fady Samuel
https://codereview.chromium.org/615583003/diff/100001/extensions/browser/extension_url_request_context_getter.h File extensions/browser/extension_url_request_context_getter.h (right): https://codereview.chromium.org/615583003/diff/100001/extensions/browser/extension_url_request_context_getter.h#newcode23 extensions/browser/extension_url_request_context_getter.h:23: public content::ShellURLRequestContextGetter { Don't rely on code from ShellURLRequestContextGetter. ...
6 years, 2 months ago (2014-09-29 20:43:55 UTC) #8
Fady Samuel
https://codereview.chromium.org/615583003/diff/100001/extensions/DEPS File extensions/DEPS (right): https://codereview.chromium.org/615583003/diff/100001/extensions/DEPS#newcode6 extensions/DEPS:6: "+content/shell/browser", Remove this dependency.
6 years, 2 months ago (2014-09-29 20:48:02 UTC) #9
Xi Han
Fady: please take a look. Thanks!
6 years, 2 months ago (2014-10-02 15:38:55 UTC) #12
Xi Han
rockot@chromium.org: I try my best to reduce the dependencies of content/shell and extensions/shell, and I ...
6 years, 2 months ago (2014-10-02 20:16:49 UTC) #14
Ken Rockot(use gerrit already)
lgtm https://codereview.chromium.org/615583003/diff/240001/extensions/shell/browser/shell_browser_context.cc File extensions/shell/browser/shell_browser_context.cc (right): https://codereview.chromium.org/615583003/diff/240001/extensions/shell/browser/shell_browser_context.cc#newcode62 extensions/shell/browser/shell_browser_context.cc:62: //set_url_request_context_getter(url_request_context_getter_.get()); Remove this?
6 years, 2 months ago (2014-10-02 22:38:38 UTC) #15
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/615583003/260001
6 years, 2 months ago (2014-10-02 23:00:09 UTC) #17
commit-bot: I haz the power
Committed patchset #7 (id:260001) as a6780040f7545014d58bdf3b93437c4b21188e2a
6 years, 2 months ago (2014-10-03 00:28:11 UTC) #18
commit-bot: I haz the power
6 years, 2 months ago (2014-10-03 00:30:03 UTC) #19
Message was sent while issue was closed. 
Patchset 7 (id:??) landed as
https://crrev.com/d0f788b79f1c3b2e544be7b3e12326deb12bb34a
Cr-Commit-Position: refs/heads/master@{#297959}

Powered by Google App Engine
This is Rietveld 408576698