extensions/browser/api/web_request/web_request_event_router_delegate.h - Issue 615583003: Introduce NetworkDelegate's implementation in extensions.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: extensions/browser/api/web_request/web_request_event_router_delegate.h

Issue 615583003: Introduce NetworkDelegate's implementation in extensions. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « extensions/browser/api/extensions_api_client.cc ('k') | extensions/browser/api/web_request/web_request_event_router_delegate.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: extensions/browser/api/web_request/web_request_event_router_delegate.h

diff --git a/extensions/browser/api/web_request/web_request_event_router_delegate.h b/extensions/browser/api/web_request/web_request_event_router_delegate.h

index 8bd33f18a3409f118588518924f30dbbb1c1a45c..7ed2614eb55768a8bcb59ee6d46e4c95c697d104 100644

--- a/extensions/browser/api/web_request/web_request_event_router_delegate.h

+++ b/extensions/browser/api/web_request/web_request_event_router_delegate.h

@@ -34,7 +34,7 @@ class WebRequestEventRouterDelegate {

// Looks up the tab and window ID for a given request.

// Called on the IO thread.

virtual void ExtractExtraRequestDetails(

- net::URLRequest* request, base::DictionaryValue* out) = 0;

+ net::URLRequest* request, base::DictionaryValue* out);

// Called to check extra parameters (e.g., tab_id, windown_id) when filtering

// event listeners.

@@ -48,7 +48,7 @@ class WebRequestEventRouterDelegate {

const std::string& extension_id,

const GURL& url,

const std::string& api_call,

- scoped_ptr<base::DictionaryValue> details) = 0;

+ scoped_ptr<base::DictionaryValue> details) {};

DISALLOW_COPY_AND_ASSIGN(WebRequestEventRouterDelegate);

};