Telemetry: Correct typo in _timeline_controller identifier.

Telemetry: Correct typo in _timeline_controller identifier.

This caused --report-silk-details to throw exceptions.

TEST=manual,thread_times_unittest

Committed: https://crrev.com/746c871436e0ac809b502ec59ced36c44ae6edf8
Cr-Commit-Position: refs/heads/master@{#297834}

[jbroman, 2014-10-01 21:09:17]

jbroman@chromium.org changed reviewers:
+ nduca@chromium.org, nednguyen@google.com

[jbroman, 2014-10-01 21:10:14]

Introduced in:
  https://codereview.chromium.org/199733007/

I guess nobody has tried to use --report-silk-details in the last 6 months?

[nednguyen, 2014-10-01 22:12:33]

On 2014/10/01 21:10:14, jbroman wrote:
> Introduced in:
>   https://codereview.chromium.org/199733007/
> 
> I guess nobody has tried to use --report-silk-details in the last 6 months?

Can you add test coverage?

[jbroman, 2014-10-01 22:29:50]

On 2014/10/01 22:12:33, nednguyen wrote:
> On 2014/10/01 21:10:14, jbroman wrote:
> > Introduced in:
> >   https://codereview.chromium.org/199733007/
> > 
> > I guess nobody has tried to use --report-silk-details in the last 6 months?
> 
> Can you add test coverage?

Done. I thought I'd looked for an easy way to add a test for this and failed.
But now I looked again and immediately found a reasonably pleasant way. :)

[nednguyen, 2014-10-01 22:41:53]

Lgtm

It would be nice if you can do some assertion on the trace categories that's
used by timeline_controller.

https://codereview.chromium.org/615253007/diff/20001/tools/perf/measurements/...
File tools/perf/measurements/thread_times_unittest.py (right):

https://codereview.chromium.org/615253007/diff/20001/tools/perf/measurements/...
tools/perf/measurements/thread_times_unittest.py:51:
self._options.report_silk_details = True
Duplication.

[jbroman, 2014-10-02 14:24:40]

On 2014/10/01 22:41:53, nednguyen wrote:
> It would be nice if you can do some assertion on the trace categories that's
> used by timeline_controller.

Done. Still LGTY?

[jbroman, 2014-10-02 14:24:46]

https://codereview.chromium.org/615253007/diff/20001/tools/perf/measurements/...
File tools/perf/measurements/thread_times_unittest.py (right):

https://codereview.chromium.org/615253007/diff/20001/tools/perf/measurements/...
tools/perf/measurements/thread_times_unittest.py:51:
self._options.report_silk_details = True
On 2014/10/01 22:41:53, nednguyen wrote:
> Duplication.

Nope, these are two separate flags. I've split this into two tests to make this
clearer.

[nednguyen, 2014-10-02 14:58:56]

The CQ bit was checked by nednguyen@google.com

[nednguyen, 2014-10-02 14:58:56]

lgtm

[commit-bot: I haz the power, 2014-10-02 14:59:25]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/615253007/60001

[commit-bot: I haz the power, 2014-10-02 15:24:10]

Committed patchset #4 (id:60001) as b24a6a3b69aaded00cb3c3d7a52783b22364986c

[commit-bot: I haz the power, 2014-10-02 15:24:40]

Patchset 4 (id:??) landed as
https://crrev.com/746c871436e0ac809b502ec59ced36c44ae6edf8
Cr-Commit-Position: refs/heads/master@{#297834}