tools/perf/measurements/thread_times.py - Issue 615253007: Telemetry: Correct typo in _timeline_controller identifier.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tools/perf/measurements/thread_times.py

Issue 615253007: Telemetry: Correct typo in _timeline_controller identifier. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: separate --report-silk-details/--report-silk-results tests Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: tools/perf/measurements/thread_times.py

diff --git a/tools/perf/measurements/thread_times.py b/tools/perf/measurements/thread_times.py

index 51f35645593edf84cf7eaf3d82a9d00edb07b5e0..e90d2b2f1b1656ce76ea833802cf4fb46612c961 100644

--- a/tools/perf/measurements/thread_times.py

+++ b/tools/perf/measurements/thread_times.py

@@ -22,7 +22,7 @@ class ThreadTimes(page_test.PageTest):

self._timeline_controller = timeline_controller.TimelineController()

if self.options.report_silk_details:

# We need the other traces in order to have any details to report.

- self.timeline_controller.trace_categories = None

+ self._timeline_controller.trace_categories = None

else:

self._timeline_controller.trace_categories = \

tracing_category_filter.CreateNoOverheadFilter().filter_string

« no previous file with comments | « no previous file | tools/perf/measurements/thread_times_unittest.py » ('j') | no next file with comments »