Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(89)

Issue 615223005: [turbofan] support all shift operands on x64 (Closed)

Created:
6 years, 2 months ago by dcarney
Modified:
6 years, 2 months ago
Reviewers:
Benedikt Meurer
CC:
v8-dev
Project:
v8
Visibility:
Public.

Description

[turbofan] support all shift operands on x64 R=bmeurer@chromium.org BUG= Committed: https://code.google.com/p/v8/source/detail?r=24388

Patch Set 1 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+152 lines, -106 lines) Patch
M src/compiler/x64/code-generator-x64.cc View 1 chunk +15 lines, -7 lines 0 comments Download
M src/compiler/x64/instruction-selector-x64.cc View 6 chunks +4 lines, -23 lines 0 comments Download
M src/x64/assembler-x64.h View 2 chunks +38 lines, -24 lines 0 comments Download
M src/x64/assembler-x64.cc View 2 chunks +26 lines, -0 lines 0 comments Download
M src/x64/disasm-x64.cc View 1 chunk +49 lines, -52 lines 0 comments Download
M test/cctest/test-disasm-x64.cc View 1 chunk +20 lines, -0 lines 0 comments Download

Messages

Total messages: 6 (3 generated)
dcarney
ptal
6 years, 2 months ago (2014-10-02 08:59:46 UTC) #4
Benedikt Meurer
LGTM
6 years, 2 months ago (2014-10-02 09:01:35 UTC) #5
dcarney
6 years, 2 months ago (2014-10-02 09:08:21 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:40001) manually as 24388 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698