Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(65)

Issue 615193004: Add layout tests for seeks to zero on streaming sources. (Closed)

Created:
6 years, 2 months ago by DaleCurtis
Modified:
6 years, 2 months ago
Reviewers:
philipj_slow
CC:
blink-reviews
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Project:
blink
Visibility:
Public.

Description

Add layout tests for seeks to zero on streaming sources. Adds testing for the Chrome side patch: https://codereview.chromium.org/621573002 BUG=412562 TEST=all tests! Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=183373

Patch Set 1 #

Total comments: 3

Patch Set 2 : Spaces! #

Unified diffs Side-by-side diffs Delta from patch set Stats (+43 lines, -7 lines) Patch
A LayoutTests/http/tests/media/audio-seekable-contains-zero-without-ranges.html View 1 chunk +33 lines, -0 lines 0 comments Download
M LayoutTests/http/tests/media/resources/load-video.php View 1 chunk +3 lines, -1 line 0 comments Download
M LayoutTests/http/tests/media/resources/serve-video.php View 1 2 chunks +7 lines, -6 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
DaleCurtis
6 years, 2 months ago (2014-10-01 00:08:35 UTC) #2
philipj_slow
LGTM % nits I've verified that the test fails without https://codereview.chromium.org/621573002 and passes with it, ...
6 years, 2 months ago (2014-10-01 10:47:19 UTC) #3
DaleCurtis
Will land this once Blink bots have had a chance to pick up the Chromium ...
6 years, 2 months ago (2014-10-07 23:27:58 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/615193004/20001
6 years, 2 months ago (2014-10-07 23:42:58 UTC) #6
commit-bot: I haz the power
6 years, 2 months ago (2014-10-08 02:52:19 UTC) #7
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as 183373

Powered by Google App Engine
This is Rietveld 408576698