components/gcm_driver/android/java/src/org/chromium/components/gcm_driver/GCMDriver.java - Issue 615153002: Enable content layer to initCommandLine on Android

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/gcm_driver/android/java/src/org/chromium/components/gcm_driver/GCMDriver.java

Issue 615153002: Enable content layer to initCommandLine on Android (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: ChromiumSyncAdapterTest#testRequestSyncWhenChromeInBackground now asserts true for CommandLine.isIn… Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/test/android/unit_tests_apk/src/org/chromium/chrome/unit_tests_apk/ChromeNativeTestApplication.java ('k') | content/public/android/java/src/org/chromium/content/app/ContentApplication.java » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/gcm_driver/android/java/src/org/chromium/components/gcm_driver/GCMDriver.java

diff --git a/components/gcm_driver/android/java/src/org/chromium/components/gcm_driver/GCMDriver.java b/components/gcm_driver/android/java/src/org/chromium/components/gcm_driver/GCMDriver.java

index e13ae1f940954907adddc9595c8aa0c61aaa3028..8c587a47cf22e33aedd418b5f3c041f0b86151cc 100644

--- a/components/gcm_driver/android/java/src/org/chromium/components/gcm_driver/GCMDriver.java

+++ b/components/gcm_driver/android/java/src/org/chromium/components/gcm_driver/GCMDriver.java

@@ -17,6 +17,7 @@

import org.chromium.base.JNINamespace;

import org.chromium.base.ThreadUtils;

import org.chromium.base.library_loader.ProcessInitException;

+import org.chromium.content.app.ContentApplication;

import org.chromium.content.browser.BrowserStartupController;

import java.util.ArrayList;

@@ -245,8 +246,7 @@ private static void launchNativeThen(Context context, Runnable task) {

return;

}

- // TODO(johnme): Call ChromeMobileApplication.initCommandLine(context) or

- // ChromeShellApplication.initCommandLine() as appropriate.

+ ContentApplication.initCommandLine(context);

try {

BrowserStartupController.get(context).startBrowserProcessesSync(false);