content/common/view_messages.h - Issue 61503003: Additional window features are not passed as a parameter to new popup windows

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/common/view_messages.h

Issue 61503003: Additional window features are not passed as a parameter to new popup windows (Closed) Base URL: http://src.chromium.org/svn/trunk/src/

Patch Set: Incorporated suggestions Created 7 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: content/common/view_messages.h

diff --git a/content/common/view_messages.h b/content/common/view_messages.h

index 1b1c634f9e55428dff9d1b1e579a9a830558fb58..eba6a6f680b0de0b1413e91f8c18d022587926e0 100644

--- a/content/common/view_messages.h

+++ b/content/common/view_messages.h

@@ -363,6 +363,11 @@ IPC_STRUCT_BEGIN(ViewHostMsg_CreateWindow_Params)

// The window features to use for the new view.

IPC_STRUCT_MEMBER(blink::WebWindowFeatures, features)

+ // The additional window features to use for the new view. We pass it

Tom Sepez 2013/11/11 23:07:59 nit: "we pass these" since features is plural.

+ // separately from 'features' above because we cannot serialize WebStrings

Tom Sepez 2013/11/11 23:07:59 nit: |features|, per chromium standard for delimit

+ // over IPC.

+ IPC_STRUCT_MEMBER(std::vector<string16>, additional_features)

IPC_STRUCT_END()

IPC_STRUCT_BEGIN(ViewHostMsg_CreateWorker_Params)

« AUTHORS ('K') | « content/browser/renderer_host/render_message_filter.cc ('k') | content/renderer/render_view_impl.cc » ('j') | no next file with comments »