Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1504)

Unified Diff: content/browser/renderer_host/render_message_filter.cc

Issue 61503003: Additional window features are not passed as a parameter to new popup windows (Closed) Base URL: http://src.chromium.org/svn/trunk/src/
Patch Set: Incorporated suggestions Created 7 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/renderer_host/render_message_filter.cc
diff --git a/content/browser/renderer_host/render_message_filter.cc b/content/browser/renderer_host/render_message_filter.cc
index 03d8798e67cb229229951bc55335d0b6bf3bfb8c..9470d04881fa841cbbf8a7f56913ce08f8d73bcb 100644
--- a/content/browser/renderer_host/render_message_filter.cc
+++ b/content/browser/renderer_host/render_message_filter.cc
@@ -456,6 +456,14 @@ void RenderMessageFilter::OnCreateWindow(
int* surface_id,
int64* cloned_session_storage_namespace_id) {
bool no_javascript_access;
+
+ // Merge the additional features into the WebWindowFeatures struct before we
+ // pass it on.
+ blink::WebWindowFeatures features = params.features;
+ for (size_t i = 0; i < params.additional_features.size(); ++i)
+ features.additionalFeatures[i] = blink::WebString(
+ params.additional_features[i]);
+
bool can_create_window =
GetContentClient()->browser()->CanCreateWindow(
params.opener_url,
@@ -465,7 +473,7 @@ void RenderMessageFilter::OnCreateWindow(
params.target_url,
params.referrer,
params.disposition,
- params.features,
+ features,
params.user_gesture,
params.opener_suppressed,
resource_context_,

Powered by Google App Engine
This is Rietveld 408576698