Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(58)

Issue 614923005: Rename all isolate_dependency_* to files. (Closed)

Created:
6 years, 2 months ago by M-A Ruel
Modified:
6 years, 2 months ago
Reviewers:
Vadim Sh.
CC:
chromium-reviews, cbentzel+watch_chromium.org, sadrul, qsr+mojo_chromium.org, Aaron Boodman, grt+watch_chromium.org, viettrungluu+watch_chromium.org, jam, yzshen+watch_chromium.org, abarth-chromium, feature-media-reviews_chromium.org, darin-cc_chromium.org, jln+watch_chromium.org, wfh+watch_chromium.org, kalyank, cc-bugs_chromium.org, erikwright+watch_chromium.org, ben+mojo_chromium.org, darin (slow to review), ben+ash_chromium.org
Base URL:
https://chromium.googlesource.com/a/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Rename all isolate_dependency_* to files. Merges the lists when relevant. This simplify the management significantly. Remove the .isolate from the '*_run' target 'includes' section. TBR=vadimsh@chromium.org BUG=swarming:148 Committed: https://crrev.com/8214754ee5771bb64dfe9605f024cfd7c241a01e Cr-Commit-Position: refs/heads/master@{#297633}

Patch Set 1 : . #

Unified diffs Side-by-side diffs Delta from patch set Stats (+192 lines, -306 lines) Patch
M ash/ash.gyp View 1 chunk +0 lines, -1 line 0 comments Download
M ash/ash_unittests.isolate View 5 chunks +5 lines, -5 lines 0 comments Download
M base/base.gyp View 1 chunk +0 lines, -1 line 0 comments Download
M base/base.isolate View 2 chunks +3 lines, -3 lines 0 comments Download
M base/base_unittests.isolate View 3 chunks +5 lines, -5 lines 0 comments Download
M breakpad/breakpad_unittests.isolate View 1 chunk +1 line, -1 line 0 comments Download
M build/common.gypi View 1 chunk +1 line, -5 lines 0 comments Download
M build/isolate.gypi View 2 chunks +0 lines, -13 lines 0 comments Download
M cc/cc_perftests.isolate View 1 chunk +1 line, -1 line 0 comments Download
M chrome/angle.isolate View 1 chunk +1 line, -1 line 0 comments Download
M chrome/angle_unittests.isolate View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser_tests.isolate View 5 chunks +36 lines, -46 lines 0 comments Download
M chrome/chrome.isolate View 5 chunks +11 lines, -15 lines 0 comments Download
M chrome/chrome_exe.gypi View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/chrome_tests.gypi View 9 chunks +0 lines, -21 lines 0 comments Download
M chrome/chrome_tests_unit.gypi View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/gl_tests.isolate View 1 chunk +1 line, -1 line 0 comments Download
M chrome/gles2_conform_test.isolate View 2 chunks +3 lines, -5 lines 0 comments Download
M chrome/gpu_unittests.isolate View 1 chunk +1 line, -1 line 0 comments Download
M chrome/installer/mini_installer.gyp View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/installer/mini_installer_tests.isolate View 1 chunk +2 lines, -4 lines 0 comments Download
M chrome/interactive_ui_tests.isolate View 4 chunks +14 lines, -24 lines 0 comments Download
M chrome/sync_integration_tests.isolate View 5 chunks +12 lines, -16 lines 0 comments Download
M chrome/tab_capture_end2end_tests.isolate View 1 chunk +1 line, -1 line 0 comments Download
M chrome/telemetry.isolate View 1 chunk +7 lines, -9 lines 0 comments Download
M chrome/telemetry_gpu_test.isolate View 2 chunks +3 lines, -3 lines 0 comments Download
M chrome/unit_tests.isolate View 7 chunks +20 lines, -30 lines 0 comments Download
M components/components_unittests.isolate View 1 chunk +1 line, -3 lines 0 comments Download
M components/nacl.gyp View 1 chunk +0 lines, -1 line 0 comments Download
M components/nacl_loader_unittests.isolate View 1 chunk +1 line, -1 line 0 comments Download
M content/content_browsertests.isolate View 5 chunks +14 lines, -18 lines 0 comments Download
M content/content_gl_tests.isolate View 3 chunks +5 lines, -5 lines 0 comments Download
M content/content_tests.gypi View 3 chunks +0 lines, -3 lines 0 comments Download
M content/content_unittests.isolate View 7 chunks +9 lines, -9 lines 0 comments Download
M media/media.gyp View 1 chunk +0 lines, -1 line 0 comments Download
M media/media_perftests.isolate View 1 chunk +1 line, -1 line 0 comments Download
M media/media_unittests.isolate View 3 chunks +5 lines, -5 lines 0 comments Download
M mojo/mojo.gyp View 1 chunk +0 lines, -1 line 0 comments Download
M mojo/mojo_apps.gypi View 1 chunk +0 lines, -1 line 0 comments Download
M mojo/mojo_apps_js_unittests.isolate View 2 chunks +5 lines, -7 lines 0 comments Download
M mojo/mojo_base.gyp View 1 chunk +0 lines, -1 line 0 comments Download
M mojo/mojo_js_unittests.isolate View 2 chunks +5 lines, -7 lines 0 comments Download
M mojo/mojo_python_unittests.isolate View 1 chunk +4 lines, -6 lines 0 comments Download
M net/net.gyp View 1 chunk +0 lines, -1 line 0 comments Download
M net/net_unittests.isolate View 3 chunks +4 lines, -6 lines 0 comments Download
M sandbox/linux/sandbox_linux.gypi View 1 chunk +0 lines, -1 line 0 comments Download
M sandbox/sandbox_linux_unittests.isolate View 1 chunk +1 line, -1 line 0 comments Download
M sql/sql.gyp View 1 chunk +0 lines, -1 line 0 comments Download
M sql/sql_unittests.isolate View 1 chunk +1 line, -1 line 0 comments Download
M testing/chromoting/chromoting_integration_tests.isolate View 3 chunks +4 lines, -4 lines 0 comments Download
M testing/chromoting/integration_tests.gyp View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/cacheinvalidation/cacheinvalidation.gyp View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/cacheinvalidation/cacheinvalidation_unittests.isolate View 1 chunk +1 line, -1 line 0 comments Download
M tools/isolate_driver.py View 1 chunk +1 line, -1 line 0 comments Download
M ui/base/ui_base_tests.isolate View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 9 (4 generated)
M-A Ruel
I think in a follow up I'll remove the 'variables' intermediary dict now that it ...
6 years, 2 months ago (2014-10-01 00:26:25 UTC) #4
Vadim Sh.
lgtm
6 years, 2 months ago (2014-10-01 01:34:31 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/614923005/60001
6 years, 2 months ago (2014-10-01 12:21:13 UTC) #7
commit-bot: I haz the power
Committed patchset #1 (id:60001) as d19a839d39d7a4c5843c8312ff8d93c03640b80e
6 years, 2 months ago (2014-10-01 13:21:51 UTC) #8
commit-bot: I haz the power
6 years, 2 months ago (2014-10-01 13:22:34 UTC) #9
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/8214754ee5771bb64dfe9605f024cfd7c241a01e
Cr-Commit-Position: refs/heads/master@{#297633}

Powered by Google App Engine
This is Rietveld 408576698