Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4548)

Unified Diff: build/common.gypi

Issue 614923005: Rename all isolate_dependency_* to files. (Closed) Base URL: https://chromium.googlesource.com/a/chromium/src.git@master
Patch Set: . Created 6 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « breakpad/breakpad_unittests.isolate ('k') | build/isolate.gypi » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: build/common.gypi
diff --git a/build/common.gypi b/build/common.gypi
index d22afdb7ddb3aa419544cc1e4026654874f2a557..6e36b8a743b8c4b03f222f84767d61f74dcca920 100644
--- a/build/common.gypi
+++ b/build/common.gypi
@@ -920,13 +920,9 @@
# dependencies verified. All the tests targets have the '_run' suffix,
# e.g. base_unittests_run runs the target base_unittests. The test
# target always calls tools/swarming_client/isolate.py. See the script's
- # --help for more information and the valid --mode values. Meant to be
- # overriden with GYP_DEFINES.
+ # --help for more information. Meant to be overriden with GYP_DEFINES.
# TODO(maruel): Remove the conditions as more configurations are
# supported.
- # NOTE: The check for disable_nacl==0 and component=="static_library"
- # can't be used here because these variables are not defined yet, but it
- # is still not supported.
['OS!="ios" and OS!="android" and chromeos==0', {
'test_isolation_mode%': 'check',
}, {
« no previous file with comments | « breakpad/breakpad_unittests.isolate ('k') | build/isolate.gypi » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698