chrome/browser/net/net_log_temp_file_unittest.cc - Issue 614893004: Refactor AppendToFile and WriteFileDescriptor

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/net/net_log_temp_file_unittest.cc

Issue 614893004: Refactor AppendToFile and WriteFileDescriptor (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Address nits Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/net/net_log_temp_file_unittest.cc

diff --git a/chrome/browser/net/net_log_temp_file_unittest.cc b/chrome/browser/net/net_log_temp_file_unittest.cc

index b3fce9e6bdbb81f0bc9b87305ae709d0593ebf9c..29791f311146ee983542efc7765c640dd08382a3 100644

--- a/chrome/browser/net/net_log_temp_file_unittest.cc

+++ b/chrome/browser/net/net_log_temp_file_unittest.cc

@@ -297,8 +297,8 @@ TEST_F(NetLogTempFileTest, DoStartClearsFile) {

// Add some junk at the end of the file.

std::string junk_data("Hello");

- EXPECT_GT(base::AppendToFile(

- net_export_log_, junk_data.c_str(), junk_data.size()), 0);

+ EXPECT_TRUE(base::AppendToFile(net_export_log_, junk_data.c_str(),

+ junk_data.size()));

int64 junk_file_size;

EXPECT_TRUE(base::GetFileSize(net_export_log_, &junk_file_size));