chrome/browser/media_galleries/win/mtp_device_operations_util.cc - Issue 614893004: Refactor AppendToFile and WriteFileDescriptor

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/media_galleries/win/mtp_device_operations_util.cc

Issue 614893004: Refactor AppendToFile and WriteFileDescriptor (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Address nits Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/media_galleries/win/mtp_device_operations_util.cc

diff --git a/chrome/browser/media_galleries/win/mtp_device_operations_util.cc b/chrome/browser/media_galleries/win/mtp_device_operations_util.cc

index c26414f69f2e9c1774808053a83b3150f78e0848..378f29a3af1d2076d848242f6e6a3546daf86bff 100644

--- a/chrome/browser/media_galleries/win/mtp_device_operations_util.cc

+++ b/chrome/browser/media_galleries/win/mtp_device_operations_util.cc

@@ -392,9 +392,8 @@ DWORD CopyDataChunkToLocalFile(IStream* stream,

base::checked_cast<int>(

std::min(bytes_read,

base::checked_cast<DWORD>(buffer.length())));

- if (base::AppendToFile(local_path, buffer.c_str(), data_len) != data_len)

- return 0U;

- return data_len;

+ return base::AppendToFile(local_path, buffer.c_str(), data_len) ? data_len

+ : 0;

}

base::string16 GetObjectIdFromName(IPortableDevice* device,