Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(212)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 614883003: Preserve order of fields when doing slow-to-fast object migration. (Closed)

Created:
6 years, 2 months ago by Igor Sheludko
Modified:
6 years, 2 months ago
Reviewers:
Jakob Kummerow
CC:
v8-dev
Project:
v8
Visibility:
Public.

Description

Preserve order of fields when doing slow-to-fast object migration. R=jkummerow@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=24594

Patch Set 1 #

Total comments: 6

Patch Set 2 : Addressed comments #

Unified diffs Side-by-side diffs Delta from patch set Stats (+98 lines, -86 lines) Patch
M src/objects.h View 1 3 chunks +9 lines, -2 lines 0 comments Download
M src/objects.cc View 1 4 chunks +87 lines, -82 lines 0 comments Download
M src/objects-inl.h View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
Igor Sheludko
PTAL
6 years, 2 months ago (2014-10-02 13:02:30 UTC) #2
Jakob Kummerow
LGTM with comments. https://codereview.chromium.org/614883003/diff/1/src/objects.cc File src/objects.cc (right): https://codereview.chromium.org/614883003/diff/1/src/objects.cc#newcode14918 src/objects.cc:14918: Handle<FixedArray> Dictionary<Derived, Shape, Key>::BuildNewIterationIndices( naming: BuildNewIterationIndices ...
6 years, 2 months ago (2014-10-06 11:47:36 UTC) #3
Igor Sheludko
Committed patchset #2 (id:40001) manually as 24594 (presubmit successful).
6 years, 2 months ago (2014-10-14 11:03:48 UTC) #5
Igor Sheludko
6 years, 2 months ago (2014-10-20 14:05:24 UTC) #6
Message was sent while issue was closed. 
https://codereview.chromium.org/614883003/diff/1/src/objects.cc
File src/objects.cc (right):

https://codereview.chromium.org/614883003/diff/1/src/objects.cc#newcode14918
src/objects.cc:14918: Handle<FixedArray> Dictionary<Derived, Shape,
Key>::BuildNewIterationIndices(
On 2014/10/06 11:47:35, Jakob wrote:
> naming: BuildNewIterationIndices sounds confusingly similar to
> GenerateNewInterationIndices. How about "BuildIterationIndicesArray" instead?

Done. Thanks!

https://codereview.chromium.org/614883003/diff/1/src/objects.cc#newcode14944
src/objects.cc:14944: 
On 2014/10/06 11:47:35, Jakob wrote:
> nit: two empty lines (doesn't presubmit complain?)

Done.

https://codereview.chromium.org/614883003/diff/1/src/objects.h
File src/objects.h (right):

https://codereview.chromium.org/614883003/diff/1/src/objects.h#newcode3586
src/objects.h:3586: // Values are direct indexes in the |HashTable| array.
On 2014/10/06 11:47:36, Jakob wrote:
> nit: s/indexes/indices/ for consistency.

Done.

Powered by Google App Engine
This is Rietveld 408576698