Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(153)

Side by Side Diff: src/objects-inl.h

Issue 614883003: Preserve order of fields when doing slow-to-fast object migration. (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: Addressed comments Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « src/objects.cc ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2012 the V8 project authors. All rights reserved. 1 // Copyright 2012 the V8 project authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 // 4 //
5 // Review notes: 5 // Review notes:
6 // 6 //
7 // - The use of macros in these inline functions may seem superfluous 7 // - The use of macros in these inline functions may seem superfluous
8 // but it is absolutely needed to make sure gcc generates optimal 8 // but it is absolutely needed to make sure gcc generates optimal
9 // code. gcc is not happy when attempting to inline too deep. 9 // code. gcc is not happy when attempting to inline too deep.
10 // 10 //
(...skipping 6884 matching lines...) Expand 10 before | Expand all | Expand 10 after
6895 } 6895 }
6896 6896
6897 6897
6898 Handle<Object> NameDictionaryShape::AsHandle(Isolate* isolate, 6898 Handle<Object> NameDictionaryShape::AsHandle(Isolate* isolate,
6899 Handle<Name> key) { 6899 Handle<Name> key) {
6900 DCHECK(key->IsUniqueName()); 6900 DCHECK(key->IsUniqueName());
6901 return key; 6901 return key;
6902 } 6902 }
6903 6903
6904 6904
6905 void NameDictionary::DoGenerateNewEnumerationIndices( 6905 Handle<FixedArray> NameDictionary::DoGenerateNewEnumerationIndices(
6906 Handle<NameDictionary> dictionary) { 6906 Handle<NameDictionary> dictionary) {
6907 DerivedDictionary::GenerateNewEnumerationIndices(dictionary); 6907 return DerivedDictionary::GenerateNewEnumerationIndices(dictionary);
6908 } 6908 }
6909 6909
6910 6910
6911 bool ObjectHashTableShape::IsMatch(Handle<Object> key, Object* other) { 6911 bool ObjectHashTableShape::IsMatch(Handle<Object> key, Object* other) {
6912 return key->SameValue(other); 6912 return key->SameValue(other);
6913 } 6913 }
6914 6914
6915 6915
6916 uint32_t ObjectHashTableShape::Hash(Handle<Object> key) { 6916 uint32_t ObjectHashTableShape::Hash(Handle<Object> key) {
6917 return Smi::cast(key->GetHash())->value(); 6917 return Smi::cast(key->GetHash())->value();
(...skipping 339 matching lines...) Expand 10 before | Expand all | Expand 10 after
7257 #undef READ_SHORT_FIELD 7257 #undef READ_SHORT_FIELD
7258 #undef WRITE_SHORT_FIELD 7258 #undef WRITE_SHORT_FIELD
7259 #undef READ_BYTE_FIELD 7259 #undef READ_BYTE_FIELD
7260 #undef WRITE_BYTE_FIELD 7260 #undef WRITE_BYTE_FIELD
7261 #undef NOBARRIER_READ_BYTE_FIELD 7261 #undef NOBARRIER_READ_BYTE_FIELD
7262 #undef NOBARRIER_WRITE_BYTE_FIELD 7262 #undef NOBARRIER_WRITE_BYTE_FIELD
7263 7263
7264 } } // namespace v8::internal 7264 } } // namespace v8::internal
7265 7265
7266 #endif // V8_OBJECTS_INL_H_ 7266 #endif // V8_OBJECTS_INL_H_
OLDNEW
« no previous file with comments | « src/objects.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698