Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(127)

Issue 61483002: Reland: [Telemetry] Fix image_decoding_measurement timeout. (Closed)

Created:
7 years, 1 month ago by tonyg
Modified:
7 years, 1 month ago
CC:
chromium-reviews, chrome-speed-team+watch_google.com, telemetry+watch_chromium.org
Base URL:
http://git.chromium.org/chromium/src.git@master
Visibility:
Public.

Description

Reland: [Telemetry] Fix image_decoding_measurement timeout. This was reverted because it caused some timeouts. The reland is the same as the original but I now preseved the original timeout values of Page.enable and Page.disable. > util.WaitFor polls which is not appropriate for PerformActionAndWaitForNavigate. > > Since DispatchNotifications blocks in recv until it gets some data, there is no > need to poll at an interval. Instead, we should call recv again as soon as > possible after dispatching a notification. > > In the case of the image decoding measurement, it runs timeline recording. There > were so many timeline messages to receive that we were not always getting to the > important Page.navigate message before timing out. > > Example: > http://build.chromium.org/p/chromium.perf/builders/Linux%20Perf%20%281%29/builds/27098 > > BUG=314375 > > Review URL: https://codereview.chromium.org/47013004 TBR=kbr@chromium.org BUG= Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=233543

Patch Set 1 #

Patch Set 2 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+27 lines, -35 lines) Patch
M tools/telemetry/telemetry/core/backends/chrome/inspector_backend.py View 1 chunk +1 line, -1 line 0 comments Download
M tools/telemetry/telemetry/core/backends/chrome/inspector_page.py View 2 chunks +23 lines, -27 lines 0 comments Download
M tools/telemetry/telemetry/core/util.py View 2 chunks +2 lines, -6 lines 0 comments Download
M tools/telemetry/telemetry/page/html_page_measurement_results_unittest.py View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 10 (0 generated)
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tonyg@chromium.org/61483002/1
7 years, 1 month ago (2013-11-06 03:57:54 UTC) #1
commit-bot: I haz the power
Step "update" is always a major failure. Look at the try server FAQ for more ...
7 years, 1 month ago (2013-11-06 04:45:17 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tonyg@chromium.org/61483002/1
7 years, 1 month ago (2013-11-06 05:17:21 UTC) #3
Ken Russell (switch to Gerrit)
I'd like to point out that sending this CL to the win_gpu, linux_gpu, mac_gpu, and ...
7 years, 1 month ago (2013-11-06 08:12:14 UTC) #4
commit-bot: I haz the power
Retried try job too often on linux_aura for step(s) browser_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_aura&number=94666
7 years, 1 month ago (2013-11-06 09:54:32 UTC) #5
tonyg
O nice, didn't realize there were trybots. I've added them.
7 years, 1 month ago (2013-11-06 14:34:59 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tonyg@chromium.org/61483002/1
7 years, 1 month ago (2013-11-06 14:38:02 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tonyg@chromium.org/61483002/390001
7 years, 1 month ago (2013-11-06 18:41:28 UTC) #8
tonyg
Unfortunately, the gpu trybots (or maybe all trybots?) are busted: https://code.google.com/p/chromium/issues/detail?id=315777 Back in the CQ. ...
7 years, 1 month ago (2013-11-06 18:42:44 UTC) #9
commit-bot: I haz the power
7 years, 1 month ago (2013-11-07 08:12:43 UTC) #10
Message was sent while issue was closed.
Change committed as 233543

Powered by Google App Engine
This is Rietveld 408576698