Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(190)

Issue 47013004: [Telemetry] Fix image_decoding_measurement timeout. (Closed)

Created:
7 years, 1 month ago by tonyg
Modified:
7 years, 1 month ago
Reviewers:
dtu, nduca
CC:
chromium-reviews, chrome-speed-team+watch_google.com, telemetry+watch_chromium.org
Base URL:
http://git.chromium.org/chromium/src.git@master
Visibility:
Public.

Description

[Telemetry] Fix image_decoding_measurement timeout. util.WaitFor polls which is not appropriate for PerformActionAndWaitForNavigate. Since DispatchNotifications blocks in recv until it gets some data, there is no need to poll at an interval. Instead, we should call recv again as soon as possible after dispatching a notification. In the case of the image decoding measurement, it runs timeline recording. There were so many timeline messages to receive that we were not always getting to the important Page.navigate message before timing out. Example: http://build.chromium.org/p/chromium.perf/builders/Linux%20Perf%20%281%29/builds/27098 BUG=314375 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=232959

Patch Set 1 #

Patch Set 2 : fix lint #

Unified diffs Side-by-side diffs Delta from patch set Stats (+28 lines, -36 lines) Patch
M tools/telemetry/telemetry/core/backends/chrome/inspector_backend.py View 1 chunk +1 line, -1 line 0 comments Download
M tools/telemetry/telemetry/core/backends/chrome/inspector_page.py View 2 chunks +24 lines, -28 lines 0 comments Download
M tools/telemetry/telemetry/core/util.py View 2 chunks +2 lines, -6 lines 0 comments Download
M tools/telemetry/telemetry/page/html_page_measurement_results_unittest.py View 1 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 7 (0 generated)
tonyg
7 years, 1 month ago (2013-11-02 05:37:15 UTC) #1
dtu
lgtdoge THIS IS THE BEST PASS_TIME_LEFT_TO_FUNC WAS THE BANE OF MY EXISLGTMENCE
7 years, 1 month ago (2013-11-05 00:13:51 UTC) #2
tonyg
On 2013/11/05 00:13:51, dtu wrote: > lgtdoge > > > THIS IS THE BEST PASS_TIME_LEFT_TO_FUNC ...
7 years, 1 month ago (2013-11-05 00:14:49 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tonyg@chromium.org/47013004/1
7 years, 1 month ago (2013-11-05 00:44:09 UTC) #4
commit-bot: I haz the power
Retried try job too often on chromium_presubmit for step(s) presubmit http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=chromium_presubmit&number=34381
7 years, 1 month ago (2013-11-05 01:22:57 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tonyg@chromium.org/47013004/100001
7 years, 1 month ago (2013-11-05 04:02:41 UTC) #6
commit-bot: I haz the power
7 years, 1 month ago (2013-11-05 13:43:56 UTC) #7
Message was sent while issue was closed.
Change committed as 232959

Powered by Google App Engine
This is Rietveld 408576698