sandbox/win/src/service_resolver_64.cc - Issue 614813002: Cleanup sandbox/ in advance of re-enabling some MSVC warnings.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: sandbox/win/src/service_resolver_64.cc

Issue 614813002: Cleanup sandbox/ in advance of re-enabling some MSVC warnings. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 6 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« sandbox/win/src/process_mitigations_test.cc ('K') | « sandbox/win/src/process_mitigations_test.cc ('k') | sandbox/win/src/target_process.cc » ('j') | sandbox/win/src/target_process.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: sandbox/win/src/service_resolver_64.cc

diff --git a/sandbox/win/src/service_resolver_64.cc b/sandbox/win/src/service_resolver_64.cc

index 03795f7c9d0ce5e82c85e1dd4d41113e1b6faf49..984cb384e2773ea8593e015ac628afb7247c2557 100644

--- a/sandbox/win/src/service_resolver_64.cc

+++ b/sandbox/win/src/service_resolver_64.cc

@@ -168,11 +168,6 @@ bool ServiceResolverThunk::IsFunctionAService(void* local_thunk) const {

NTSTATUS ServiceResolverThunk::PerformPatch(void* local_thunk,

void* remote_thunk) {

- ServiceFullThunk* full_local_thunk =

- reinterpret_cast<ServiceFullThunk*>(local_thunk);

- ServiceFullThunk* full_remote_thunk =

- reinterpret_cast<ServiceFullThunk*>(remote_thunk);

// Patch the original code.

ServiceEntry local_service;

DCHECK_NT(GetInternalThunkSize() >= sizeof(local_service));

« sandbox/win/src/process_mitigations_test.cc ('K') | « sandbox/win/src/process_mitigations_test.cc ('k') | sandbox/win/src/target_process.cc » ('j') | sandbox/win/src/target_process.cc » ('J')