sandbox/win/src/process_mitigations_test.cc - Issue 614813002: Cleanup sandbox/ in advance of re-enabling some MSVC warnings.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: sandbox/win/src/process_mitigations_test.cc

Issue 614813002: Cleanup sandbox/ in advance of re-enabling some MSVC warnings. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 6 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: sandbox/win/src/process_mitigations_test.cc

diff --git a/sandbox/win/src/process_mitigations_test.cc b/sandbox/win/src/process_mitigations_test.cc

index e6062564fe0dffcb826c0ad9f366f3f6f5a9d781..4d2e9c6e9562a6abdd3488afaa2a4636cc893fac 100644

--- a/sandbox/win/src/process_mitigations_test.cc

+++ b/sandbox/win/src/process_mitigations_test.cc

@@ -165,10 +165,10 @@ SBOX_TESTS_COMMAND int CheckDep(int argc, wchar_t **argv) {

return SBOX_TEST_THIRD_ERROR;

}

- const int MEM_EXECUTE_OPTION_ENABLE = 1;

- const int MEM_EXECUTE_OPTION_DISABLE = 2;

- const int MEM_EXECUTE_OPTION_ATL7_THUNK_EMULATION = 4;

- const int MEM_EXECUTE_OPTION_PERMANENT = 8;

+ static const int MEM_EXECUTE_OPTION_ENABLE = 1;

Peter Kasting 2014/09/29 23:09:25 See comments in previous file.

+ static const int MEM_EXECUTE_OPTION_DISABLE = 2;

+ static const int MEM_EXECUTE_OPTION_ATL7_THUNK_EMULATION = 4;

+ static const int MEM_EXECUTE_OPTION_PERMANENT = 8;

dep_flags &= 0xff;

if (dep_flags != (MEM_EXECUTE_OPTION_DISABLE |

« sandbox/win/src/process_mitigations.cc ('K') | « sandbox/win/src/process_mitigations.cc ('k') | sandbox/win/src/service_resolver_64.cc » ('j') | sandbox/win/src/target_process.cc » ('J')