Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(40)

Issue 614783002: Remove page_set argument from benchmark.CreateExpectations (Closed)

Created:
6 years, 2 months ago by nednguyen
Modified:
6 years, 2 months ago
CC:
chromium-reviews, darin-cc_chromium.org, jam, piman+watch_chromium.org, telemetry+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Remove page_set argument from benchmark.CreateExpectations to limit the access to page_set (user_story) BUG=418278 Committed: https://crrev.com/b91e7865b4b62add4e16b5e18becf12316beb0db Cr-Commit-Position: refs/heads/master@{#297267}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -10 lines) Patch
M content/test/gpu/gpu_tests/context_lost.py View 1 chunk +1 line, -1 line 0 comments Download
M content/test/gpu/gpu_tests/gpu_process.py View 1 chunk +1 line, -1 line 0 comments Download
M content/test/gpu/gpu_tests/hardware_accelerated_feature.py View 1 chunk +1 line, -1 line 0 comments Download
M content/test/gpu/gpu_tests/maps.py View 1 chunk +1 line, -1 line 0 comments Download
M content/test/gpu/gpu_tests/memory_test.py View 1 chunk +1 line, -1 line 0 comments Download
M content/test/gpu/gpu_tests/pixel.py View 1 chunk +1 line, -1 line 0 comments Download
M content/test/gpu/gpu_tests/screenshot_sync.py View 1 chunk +1 line, -1 line 0 comments Download
M content/test/gpu/gpu_tests/webgl_conformance.py View 1 chunk +1 line, -1 line 0 comments Download
M tools/telemetry/telemetry/benchmark.py View 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 10 (3 generated)
nednguyen
6 years, 2 months ago (2014-09-29 20:12:52 UTC) #2
dtu
non-owners lgtm
6 years, 2 months ago (2014-09-29 20:15:19 UTC) #4
nduca
lgtm also
6 years, 2 months ago (2014-09-29 20:29:16 UTC) #5
Ken Russell (switch to Gerrit)
lgtm
6 years, 2 months ago (2014-09-29 21:03:56 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/614783002/1
6 years, 2 months ago (2014-09-29 21:07:29 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1) as c321be42033fdbd37f26101a5701ccc54f39e1e1
6 years, 2 months ago (2014-09-29 21:16:07 UTC) #9
commit-bot: I haz the power
6 years, 2 months ago (2014-09-29 21:16:56 UTC) #10
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/b91e7865b4b62add4e16b5e18becf12316beb0db
Cr-Commit-Position: refs/heads/master@{#297267}

Powered by Google App Engine
This is Rietveld 408576698