Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(202)

Unified Diff: tools/telemetry/telemetry/benchmark.py

Issue 614783002: Remove page_set argument from benchmark.CreateExpectations (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « content/test/gpu/gpu_tests/webgl_conformance.py ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/telemetry/telemetry/benchmark.py
diff --git a/tools/telemetry/telemetry/benchmark.py b/tools/telemetry/telemetry/benchmark.py
index 5d2dcc5d1577b3b2d6927a1e789c815877438cd6..ec2c87534a526b12cf688d097cb2a1ffa1ce988f 100644
--- a/tools/telemetry/telemetry/benchmark.py
+++ b/tools/telemetry/telemetry/benchmark.py
@@ -85,7 +85,7 @@ class Benchmark(command_line.Command):
pt._enabled_strings = self._enabled_strings
ps = self.CreatePageSet(finder_options)
- expectations = self.CreateExpectations(ps)
+ expectations = self.CreateExpectations()
self._DownloadGeneratedProfileArchive(finder_options)
@@ -196,7 +196,7 @@ class Benchmark(command_line.Command):
return cls.PageSetClass()()
@classmethod
- def CreateExpectations(cls, ps): # pylint: disable=W0613
+ def CreateExpectations(cls): # pylint: disable=W0613
"""Get the expectations this test will run with.
By default, it will create an empty expectations set. Override to generate
« no previous file with comments | « content/test/gpu/gpu_tests/webgl_conformance.py ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698