Issue 614353006: Detect SHA-1 when it appears in certificate chains

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 614353006: Detect SHA-1 when it appears in certificate chains (Closed)

Created:
6 years, 2 months ago by Ryan Sleevi

Modified:
6 years, 2 months ago

Reviewers:
davidben

CC:
chromium-reviews, cbentzel+watch_chromium.org

Base URL:
https://chromium.googlesource.com/chromium/src.git@2171

Project:
chromium

Visibility:
Public.

Detect SHA-1 when it appears in certificate chains BUG=401365 TBR=davidben Review URL: https://codereview.chromium.org/509273002 Cr-Commit-Position: refs/heads/master@{#297307} (cherry picked from commit b92e6f5c2a5271850a39afa1254d41ccc34ec5e6) Committed: https://chromium.googlesource.com/chromium/src/+/c08f7ae501a11842f5f7e0967944a0a3cdd9fdcc

Created: 6 years, 2 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+98 lines, -31 lines)			Patch
M	net/cert/cert_verify_proc_android.cc	View	2 chunks	+32 lines, -0 lines	0 comments	Download
M	net/cert/cert_verify_proc_mac.cc	View	1 chunk	+7 lines, -0 lines	0 comments	Download
M	net/cert/cert_verify_proc_nss.cc	View	1 chunk	+6 lines, -0 lines	0 comments	Download
M	net/cert/cert_verify_proc_openssl.cc	View	1 chunk	+7 lines, -1 line	0 comments	Download
M	net/cert/cert_verify_proc_unittest.cc	View	9 chunks	+35 lines, -28 lines	0 comments	Download
M	net/cert/cert_verify_proc_win.cc	View	1 chunk	+7 lines, -0 lines	0 comments	Download
M	net/cert/cert_verify_result.h	View	1 chunk	+2 lines, -1 line	0 comments	Download
M	net/cert/cert_verify_result.cc	View	1 chunk	+2 lines, -1 line	0 comments	Download

Total messages: 3 (1 generated)

Ryan Sleevi

6 years, 2 months ago (2014-10-02 00:48:33 UTC) #3

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
c08f7ae501a11842f5f7e0967944a0a3cdd9fdcc (presubmit successful).