Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(438)

Unified Diff: net/cert/cert_verify_proc_mac.cc

Issue 614353006: Detect SHA-1 when it appears in certificate chains (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@2171
Patch Set: Created 6 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « net/cert/cert_verify_proc_android.cc ('k') | net/cert/cert_verify_proc_nss.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: net/cert/cert_verify_proc_mac.cc
diff --git a/net/cert/cert_verify_proc_mac.cc b/net/cert/cert_verify_proc_mac.cc
index 97c0bf13de63aa81d39a77790a233eb90426aa3c..709922598eaf20985dd67a50661dd9692ab33efc 100644
--- a/net/cert/cert_verify_proc_mac.cc
+++ b/net/cert/cert_verify_proc_mac.cc
@@ -227,6 +227,13 @@ void GetCertChainInfo(CFArrayRef cert_chain,
verify_result->has_md4 = true;
} else if (CSSMOIDEqual(alg_oid, &CSSMOID_MD5WithRSA)) {
verify_result->has_md5 = true;
+ } else if (CSSMOIDEqual(alg_oid, &CSSMOID_SHA1WithRSA) ||
+ CSSMOIDEqual(alg_oid, &CSSMOID_SHA1WithRSA_OIW) ||
+ CSSMOIDEqual(alg_oid, &CSSMOID_SHA1WithDSA) ||
+ CSSMOIDEqual(alg_oid, &CSSMOID_SHA1WithDSA_CMS) ||
+ CSSMOIDEqual(alg_oid, &CSSMOID_SHA1WithDSA_JDK) ||
+ CSSMOIDEqual(alg_oid, &CSSMOID_ECDSA_WithSHA1)) {
+ verify_result->has_sha1 = true;
}
}
if (!verified_cert)
« no previous file with comments | « net/cert/cert_verify_proc_android.cc ('k') | net/cert/cert_verify_proc_nss.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698