DescriptionRevert of Pending tasks in a message loop should be deleted before shutting down Blink (patchset #9 id:160001 of https://codereview.chromium.org/583043005/)
Reason for revert:
BUG=418206
broke canary AGAIN! please do NOT reland without fixing! https://code.google.com/p/chromium/issues/detail?id=418206
Original issue's description:
> Pending tasks in a message loop should be deleted before shutting down Blink
>
> Currently Blink is shut down before all the pending tasks in the message loop are deleted. This is problematic in Oilpan because a destructor of the pending tasks can touch Oilpan objects. Because Oilpan is already detached from the renderer thread at that point, touching Oilpan objects in the destructor leads to a crash. (See the bug report for a concrete scenario.)
>
> To prevent Blink objects from getting accessed after Blink is shut down, this CL deletes all pending tasks in a message loop before shutting down Blink.
>
> BUG=411026
> TEST=None. I cannot reproduce the crash.
>
> Committed: https://crrev.com/fdd5612c20f777e1279efd7c1e99d82ed04afaaf
> Cr-Commit-Position: refs/heads/master@{#296697}
>
> Committed: https://crrev.com/16d32a9f7f6d1ebb639cacedb5156272a9fec764
> Cr-Commit-Position: refs/heads/master@{#297338}
TBR=tkent@chromium.org,jochen@chromium.org,jamesr@chromium.org,ager@chromium.org,jar@chromium.org,haraken@chromium.org
NOTREECHECKS=true
NOTRY=true
BUG=411026
Committed: https://crrev.com/e10fb6c6993651bfcfa26c0d28d83a6cbabb4ffd
Cr-Commit-Position: refs/heads/master@{#297506}
Patch Set 1 #
Created: 6 years, 2 months ago
(Patch set is too large to download)
Messages
Total messages: 5 (0 generated)
|