Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(306)

Issue 614233002: Revert of Pending tasks in a message loop should be deleted before shutting down Blink (Closed)

Created:
6 years, 2 months ago by kareng
Modified:
6 years, 2 months ago
CC:
chromium-reviews, mkwst+moarreviews-renderer_chromium.org, jam, erikwright+watch_chromium.org, sadrul, darin-cc_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Revert of Pending tasks in a message loop should be deleted before shutting down Blink (patchset #9 id:160001 of https://codereview.chromium.org/583043005/) Reason for revert: BUG=418206 broke canary AGAIN! please do NOT reland without fixing! https://code.google.com/p/chromium/issues/detail?id=418206 Original issue's description: > Pending tasks in a message loop should be deleted before shutting down Blink > > Currently Blink is shut down before all the pending tasks in the message loop are deleted. This is problematic in Oilpan because a destructor of the pending tasks can touch Oilpan objects. Because Oilpan is already detached from the renderer thread at that point, touching Oilpan objects in the destructor leads to a crash. (See the bug report for a concrete scenario.) > > To prevent Blink objects from getting accessed after Blink is shut down, this CL deletes all pending tasks in a message loop before shutting down Blink. > > BUG=411026 > TEST=None. I cannot reproduce the crash. > > Committed: https://crrev.com/fdd5612c20f777e1279efd7c1e99d82ed04afaaf > Cr-Commit-Position: refs/heads/master@{#296697} > > Committed: https://crrev.com/16d32a9f7f6d1ebb639cacedb5156272a9fec764 > Cr-Commit-Position: refs/heads/master@{#297338} TBR=tkent@chromium.org,jochen@chromium.org,jamesr@chromium.org,ager@chromium.org,jar@chromium.org,haraken@chromium.org NOTREECHECKS=true NOTRY=true BUG=411026 Committed: https://crrev.com/e10fb6c6993651bfcfa26c0d28d83a6cbabb4ffd Cr-Commit-Position: refs/heads/master@{#297506}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -33 lines) Patch
M content/renderer/render_thread_impl.h View 2 chunks +0 lines, -7 lines 0 comments Download
M content/renderer/render_thread_impl.cc View 2 chunks +4 lines, -19 lines 0 comments Download
M content/renderer/renderer_main.cc View 3 chunks +6 lines, -7 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
kareng
Created Revert of Pending tasks in a message loop should be deleted before shutting down ...
6 years, 2 months ago (2014-09-30 21:33:05 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/614233002/1
6 years, 2 months ago (2014-09-30 21:34:10 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1) as f8674201edc55cb4ce35f7dd6556e073356ba731
6 years, 2 months ago (2014-09-30 21:35:29 UTC) #3
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/e10fb6c6993651bfcfa26c0d28d83a6cbabb4ffd Cr-Commit-Position: refs/heads/master@{#297506}
6 years, 2 months ago (2014-09-30 21:36:18 UTC) #4
haraken
6 years, 2 months ago (2014-09-30 23:26:35 UTC) #5
Message was sent while issue was closed.
LGTM. Sorry about the breakage...

Powered by Google App Engine
This is Rietveld 408576698