Issue 614223004: Use the correct v8 context for conversions when calling into the plugin from JS

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 614223004: Use the correct v8 context for conversions when calling into the plugin from JS (Closed)

Created:
6 years, 2 months ago by raymes

Modified:
6 years, 2 months ago

Reviewers:

CC:
chromium-reviews, mkwst+moarreviews-renderer_chromium.org, darin-cc_chromium.org, jam

Base URL:
https://chromium.googlesource.com/chromium/src.git@2171

Project:
chromium

Visibility:
Public.

More Reviews

Description

Use the correct v8 context for conversions when calling into the plugin from JS Previously we were using the plugin context when converting objects during calls into the plugin from JS. As decided previously in https://codereview.chromium.org/555583003/ we should always use the caller's context in these circumstances. This CL also separates the checks in PepperPluginInstanceImpl::GetContext to help diagnose crbug.com/416311. BUG=416311 Review URL: https://codereview.chromium.org/588083002 Cr-Commit-Position: refs/heads/master@{#297136} (cherry picked from commit 816f98b97b87b84e2e1e6cff7dd1f4da9749cc2c) Committed: https://chromium.googlesource.com/chromium/src/+/6975ef66dad045b343891e0fcbf737c8ebfac89c

Patch Set 1 #

Created: 6 years, 2 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+37 lines, -20 lines)			Patch
M	content/renderer/pepper/message_channel.cc	View	2 chunks	+2 lines, -2 lines	0 comments	Download
M	content/renderer/pepper/pepper_plugin_instance_impl.h	View	1 chunk	+6 lines, -2 lines	0 comments	Download
M	content/renderer/pepper/pepper_plugin_instance_impl.cc	View	1 chunk	+11 lines, -6 lines	0 comments	Download
M	content/renderer/pepper/pepper_try_catch.h	View	3 chunks	+4 lines, -2 lines	0 comments	Download
M	content/renderer/pepper/pepper_try_catch.cc	View	3 chunks	+12 lines, -6 lines	0 comments	Download
M	content/renderer/pepper/ppb_var_deprecated_impl.cc	View	2 chunks	+2 lines, -2 lines	0 comments	Download

Messages

Total messages: 1 (0 generated)

Expand Messages | Collapse Messages

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as 6975ef6.

Expand Messages | Collapse Messages