Use the correct v8 context for conversions when calling into the plugin from JS

Use the correct v8 context for conversions when calling into the plugin from JS

Previously we were using the plugin context when converting objects during calls
into the plugin from JS. As decided previously in https://codereview.chromium.org/555583003/
we should always use the caller's context in these circumstances.

This CL also separates the checks in PepperPluginInstanceImpl::GetContext to
help diagnose crbug.com/416311.

BUG=416311
Committed: https://crrev.com/816f98b97b87b84e2e1e6cff7dd1f4da9749cc2c
Cr-Commit-Position: refs/heads/master@{#297136}

[raymes, 2014-09-23 00:31:32]

raymes@chromium.org changed reviewers:
+ dmichael@chromium.org

[raymes, 2014-09-23 00:31:32]

I forgot to send this out yesterday :(

[dmichael (off chromium), 2014-09-23 16:16:54]

lgtm

https://codereview.chromium.org/588083002/diff/1/content/renderer/pepper/pepp...
File content/renderer/pepper/pepper_plugin_instance_impl.cc (right):

https://codereview.chromium.org/588083002/diff/1/content/renderer/pepper/pepp...
content/renderer/pepper/pepper_plugin_instance_impl.cc:675:
v8::Local<v8::Context> PepperPluginInstanceImpl::GetContext() {
Maybe we should rename this to "GetMainWorldContext" and comment that it should
only be used when that's the correct context, or the context doesn't matter
(like when dispatching a MessageEvent, since the event will get re-constituted
in the listeners' respective contexts anyway).

[raymes, 2014-09-24 00:19:45]

https://codereview.chromium.org/588083002/diff/1/content/renderer/pepper/pepp...
File content/renderer/pepper/pepper_plugin_instance_impl.cc (right):

https://codereview.chromium.org/588083002/diff/1/content/renderer/pepper/pepp...
content/renderer/pepper/pepper_plugin_instance_impl.cc:675:
v8::Local<v8::Context> PepperPluginInstanceImpl::GetContext() {
On 2014/09/23 16:16:54, dmichael wrote:
> Maybe we should rename this to "GetMainWorldContext" and comment that it
should
> only be used when that's the correct context, or the context doesn't matter
> (like when dispatching a MessageEvent, since the event will get re-constituted
> in the listeners' respective contexts anyway).

Done.

[raymes, 2014-09-24 00:19:48]

The CQ bit was checked by raymes@chromium.org

[commit-bot: I haz the power, 2014-09-24 00:20:26]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/588083002/20001

[commit-bot: I haz the power, 2014-09-24 00:24:56]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-09-24 00:24:57]

Try jobs failed on following builders:
  ios_dbg_simulator on tryserver.chromium.mac
(http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_dbg_simulator...)
  ios_rel_device on tryserver.chromium.mac
(http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_rel_device/bu...)

[raymes, 2014-09-29 04:03:44]

The CQ bit was checked by raymes@chromium.org

[commit-bot: I haz the power, 2014-09-29 04:04:46]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/588083002/20001

[commit-bot: I haz the power, 2014-09-29 04:14:48]

Committed patchset #2 (id:20001) as 5161ffdaf82d7b41c62cba89796f9f27777899d3

[commit-bot: I haz the power, 2014-09-29 04:15:30]

Patchset 2 (id:??) landed as
https://crrev.com/816f98b97b87b84e2e1e6cff7dd1f4da9749cc2c
Cr-Commit-Position: refs/heads/master@{#297136}