Issue 614133003: Various Feedback fixes.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 614133003: Various Feedback fixes. (Closed)

Created:
6 years, 2 months ago by rkc

Modified:
6 years, 2 months ago

Reviewers:
rkc

CC:
chromium-reviews, arv+watch_chromium.org

Base URL:
https://chromium.googlesource.com/chromium/src.git@2125

Project:
chromium

Visibility:
Public.

Various Feedback fixes. This CL fixes two issues. . It brings up a scroll bar if the text in the feedback window doesn't fit in the space available on screen (this happens when the user sets the page zoom too 120% or above) . Sets the focus to the description field when the feedback app starts. TBR=rkc@chromium.org BUG=295999, 330139 Review URL: https://codereview.chromium.org/511393002 Cr-Commit-Position: refs/heads/master@{#292530} (cherry picked from commit 8b02d82fc496c87bba7607ad3f903ff573c73e38) Committed: https://chromium.googlesource.com/chromium/src/+/70340f254d2a782884be7a641f6959f215d5ed12

Created: 6 years, 2 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+3 lines, -0 lines)			Patch
	M	chrome/browser/resources/feedback/css/feedback.css	View		1 chunk	+1 line, -0 lines	0 comments	Download
	M	chrome/browser/resources/feedback/js/feedback.js	View		1 chunk	+2 lines, -0 lines	0 comments	Download

Total messages: 1 (0 generated)

rkc

6 years, 2 months ago (2014-09-30 17:41:34 UTC) #1

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
70340f254d2a782884be7a641f6959f215d5ed12 (presubmit successful).