Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(10)

Issue 511393002: Various Feedback fixes. (Closed)

Created:
6 years, 3 months ago by rkc
Modified:
6 years, 3 months ago
Reviewers:
xiyuan
CC:
chromium-reviews, arv+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Various Feedback fixes. This CL fixes two issues. . It brings up a scroll bar if the text in the feedback window doesn't fit in the space available on screen (this happens when the user sets the page zoom too 120% or above) . Sets the focus to the description field when the feedback app starts. R=xiyuan@chromium.org BUG=295999, 330139 Committed: https://crrev.com/8b02d82fc496c87bba7607ad3f903ff573c73e38 Cr-Commit-Position: refs/heads/master@{#292530}

Patch Set 1 #

Total comments: 2

Patch Set 2 : #

Total comments: 2

Patch Set 3 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -0 lines) Patch
M chrome/browser/resources/feedback/css/feedback.css View 1 2 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/resources/feedback/js/feedback.js View 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 10 (0 generated)
rkc
6 years, 3 months ago (2014-08-28 21:46:06 UTC) #1
xiyuan
https://codereview.chromium.org/511393002/diff/1/chrome/browser/resources/feedback/css/feedback.css File chrome/browser/resources/feedback/css/feedback.css (right): https://codereview.chromium.org/511393002/diff/1/chrome/browser/resources/feedback/css/feedback.css#newcode14 chrome/browser/resources/feedback/css/feedback.css:14: overflow-y: auto; Do we need to worry about overflow-x?
6 years, 3 months ago (2014-08-28 21:47:55 UTC) #2
rkc
https://codereview.chromium.org/511393002/diff/1/chrome/browser/resources/feedback/css/feedback.css File chrome/browser/resources/feedback/css/feedback.css (right): https://codereview.chromium.org/511393002/diff/1/chrome/browser/resources/feedback/css/feedback.css#newcode14 chrome/browser/resources/feedback/css/feedback.css:14: overflow-y: auto; On 2014/08/28 21:47:55, xiyuan wrote: > Do ...
6 years, 3 months ago (2014-08-28 21:59:03 UTC) #3
xiyuan
lgtm https://codereview.chromium.org/511393002/diff/20001/chrome/browser/resources/feedback/css/feedback.css File chrome/browser/resources/feedback/css/feedback.css (right): https://codereview.chromium.org/511393002/diff/20001/chrome/browser/resources/feedback/css/feedback.css#newcode15 chrome/browser/resources/feedback/css/feedback.css:15: overflow-y: auto; nit: simplify to "overflow: auto"
6 years, 3 months ago (2014-08-28 22:13:04 UTC) #4
rkc
https://codereview.chromium.org/511393002/diff/20001/chrome/browser/resources/feedback/css/feedback.css File chrome/browser/resources/feedback/css/feedback.css (right): https://codereview.chromium.org/511393002/diff/20001/chrome/browser/resources/feedback/css/feedback.css#newcode15 chrome/browser/resources/feedback/css/feedback.css:15: overflow-y: auto; On 2014/08/28 22:13:04, xiyuan wrote: > nit: ...
6 years, 3 months ago (2014-08-28 22:16:19 UTC) #5
rkc
The CQ bit was checked by rkc@chromium.org
6 years, 3 months ago (2014-08-28 22:16:23 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rkc@chromium.org/511393002/40001
6 years, 3 months ago (2014-08-28 22:17:59 UTC) #7
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: ios_dbg_simulator on tryserver.chromium.mac ...
6 years, 3 months ago (2014-08-29 00:01:49 UTC) #8
commit-bot: I haz the power
Committed patchset #3 (id:40001) as 154e655127e27c5df9555692f2df8f744513aee8
6 years, 3 months ago (2014-08-29 01:02:52 UTC) #9
commit-bot: I haz the power
6 years, 3 months ago (2014-09-10 03:04:38 UTC) #10
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/8b02d82fc496c87bba7607ad3f903ff573c73e38
Cr-Commit-Position: refs/heads/master@{#292530}

Powered by Google App Engine
This is Rietveld 408576698