Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(539)

Issue 614103009: [Merge] User Person/People instead of User/Users everywhere profile related. (Closed)

Created:
6 years, 2 months ago by noms (inactive)
Modified:
6 years, 2 months ago
Reviewers:
noms (inactive)
CC:
chromium-reviews, dbeam+watch-options_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@2171
Project:
chromium
Visibility:
Public.

Description

[Merge] User Person/People instead of User/Users everywhere profile related. Previously we were only doing this if the --new-avatar-menu was flipped. This is a two-part CL. This CL removes the usages of the strings, but not the strings themselves, since that involves some renaming and I'd like to merge this to M39. The CL that actually removes the unused strings is: https://codereview.chromium.org/603023004/ XIB changes: use a different string ID for the profiles menu in the menu bar. BUG=405988 TBR=noms@chromium.org Review URL: https://codereview.chromium.org/611033002 Cr-Commit-Position: refs/heads/master@{#297222} (cherry picked from commit 7252caf5868751e1f9036484b5741e85a19318a9) Committed: https://chromium.googlesource.com/chromium/src/+/af7baf974c40cd215850ea436e7661f919bc1b25

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+21 lines, -51 lines) Patch
M chrome/app/nibs/MainMenu.xib View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/cocoa/profiles/profile_menu_controller.mm View 3 chunks +7 lines, -16 lines 0 comments Download
M chrome/browser/ui/webui/options/browser_options_handler.cc View 4 chunks +5 lines, -15 lines 0 comments Download
M chrome/browser/ui/webui/options/manage_profile_handler.cc View 4 chunks +8 lines, -19 lines 0 comments Download

Messages

Total messages: 1 (0 generated)
noms (inactive)
6 years, 2 months ago (2014-10-02 18:03:00 UTC) #1
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
af7baf974c40cd215850ea436e7661f919bc1b25 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698