Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(266)

Issue 611033002: User Person/People instead of User/Users everywhere profile related. (Closed)

Created:
6 years, 2 months ago by noms (inactive)
Modified:
6 years, 2 months ago
CC:
chromium-reviews, dbeam+watch-options_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

User Person/People instead of User/Users everywhere profile related. Previously we were only doing this if the --new-avatar-menu was flipped. This is a two-part CL. This CL removes the usages of the strings, but not the strings themselves, since that involves some renaming and I'd like to merge this to M39. The CL that actually removes the unused strings is: https://codereview.chromium.org/603023004/ XIB changes: use a different string ID for the profiles menu in the menu bar. BUG=405988 Committed: https://crrev.com/7252caf5868751e1f9036484b5741e85a19318a9 Cr-Commit-Position: refs/heads/master@{#297222}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+21 lines, -51 lines) Patch
M chrome/app/nibs/MainMenu.xib View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/cocoa/profiles/profile_menu_controller.mm View 3 chunks +7 lines, -16 lines 0 comments Download
M chrome/browser/ui/webui/options/browser_options_handler.cc View 4 chunks +5 lines, -15 lines 0 comments Download
M chrome/browser/ui/webui/options/manage_profile_handler.cc View 4 chunks +8 lines, -19 lines 0 comments Download

Messages

Total messages: 10 (2 generated)
noms (inactive)
Hi Dan & Alexei, Here is part 1 of a CL to clean up the ...
6 years, 2 months ago (2014-09-29 15:24:13 UTC) #2
Alexei Svitkine (slow)
Please add a XIB Changes: section to the description, since you're changing one.
6 years, 2 months ago (2014-09-29 15:29:48 UTC) #3
noms (inactive)
Done. On 2014/09/29 15:29:48, Alexei Svitkine wrote: > Please add a XIB Changes: section to ...
6 years, 2 months ago (2014-09-29 15:31:21 UTC) #4
Alexei Svitkine (slow)
cocoa lgtm
6 years, 2 months ago (2014-09-29 15:41:43 UTC) #5
Dan Beam
lgtm
6 years, 2 months ago (2014-09-29 18:53:32 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/611033002/1
6 years, 2 months ago (2014-09-29 18:56:27 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1) as e6dcff7c138dae8a3c708d550a9f47042623be84
6 years, 2 months ago (2014-09-29 19:09:36 UTC) #9
commit-bot: I haz the power
6 years, 2 months ago (2014-09-29 19:10:41 UTC) #10
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/7252caf5868751e1f9036484b5741e85a19318a9
Cr-Commit-Position: refs/heads/master@{#297222}

Powered by Google App Engine
This is Rietveld 408576698