Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(152)

Unified Diff: components/autofill/core/common/password_form_fill_data.h

Issue 614023002: [Password manager] Relplace the FormFieldData vector from autofill::FormData with named fields… (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Incorporated nit from Vaclav's review. Created 6 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/autofill/core/common/password_form_fill_data.h
diff --git a/components/autofill/core/common/password_form_fill_data.h b/components/autofill/core/common/password_form_fill_data.h
index 14c4759865bc6d91492623af80af1b64bbfc6cf9..31333d2b83b1740336059a893bf6109d758cdf38 100644
--- a/components/autofill/core/common/password_form_fill_data.h
+++ b/components/autofill/core/common/password_form_fill_data.h
@@ -39,9 +39,22 @@ struct PasswordFormFillData {
typedef std::map<UsernamesCollectionKey,
std::vector<base::string16> > UsernamesCollection;
- // Identifies the HTML form on the page and preferred username/password for
- // login.
- FormData basic_data;
+ // The name of the form.
+ base::string16 name;
+
+ // An origin is (scheme, host, port, path and fragment identifier) only; it is
+ // just exactly a URL with the query string removed.
+ GURL origin;
+
+ // The action target of the form.
+ GURL action;
+
+ // True if this form was submitted by a user gesture and not javascript.
+ bool user_submitted;
+
+ // Username and password input fields in the form.
+ FormFieldData username_field;
+ FormFieldData password_field;
// The signon realm of the preferred user/pass pair.
std::string preferred_realm;

Powered by Google App Engine
This is Rietveld 408576698