Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(144)

Unified Diff: components/autofill/core/common/password_form_fill_data.cc

Issue 614023002: [Password manager] Relplace the FormFieldData vector from autofill::FormData with named fields… (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Incorporated nit from Vaclav's review. Created 6 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/autofill/core/common/password_form_fill_data.cc
diff --git a/components/autofill/core/common/password_form_fill_data.cc b/components/autofill/core/common/password_form_fill_data.cc
index ffc3db715c83893b416b88ac35599fccdd289f37..714e8f57b5df5b6f12b975d1619dfcfade99458a 100644
--- a/components/autofill/core/common/password_form_fill_data.cc
+++ b/components/autofill/core/common/password_form_fill_data.cc
@@ -22,7 +22,8 @@ bool UsernamesCollectionKey::operator<(
return realm < other.realm;
}
-PasswordFormFillData::PasswordFormFillData() : wait_for_username(false) {
+PasswordFormFillData::PasswordFormFillData()
+ : user_submitted(false), wait_for_username(false) {
}
PasswordFormFillData::~PasswordFormFillData() {
@@ -47,11 +48,12 @@ void InitPasswordFormFillData(
password_field.form_control_type = "password";
// Fill basic form data.
- result->basic_data.name = form_on_page.form_data.name;
- result->basic_data.origin = form_on_page.origin;
- result->basic_data.action = form_on_page.action;
- result->basic_data.fields.push_back(username_field);
- result->basic_data.fields.push_back(password_field);
+ result->name = form_on_page.form_data.name;
+ result->origin = form_on_page.origin;
+ result->action = form_on_page.action;
+ result->user_submitted = form_on_page.form_data.user_submitted;
+ result->username_field = username_field;
+ result->password_field = password_field;
result->wait_for_username = wait_for_username_before_autofill;
result->preferred_realm = preferred_match->original_signon_realm;

Powered by Google App Engine
This is Rietveld 408576698