[Password manager] Relplace the FormFieldData vector from autofill::FormData with named fields…

components/autofill/core/common/form_data.h

Index: components/autofill/core/common/form_data.h
diff --git a/components/autofill/core/common/form_data.h b/components/autofill/core/common/form_data.h
index ffbc204b61bc864b2571619bbf780db71c57c21a..e4c9a7b1aee6cbe27c7417363f1d1cd37a78b92a 100644
--- a/components/autofill/core/common/form_data.h
+++ b/components/autofill/core/common/form_data.h
@@ -35,6 +35,14 @@ struct FormData {
   GURL action;
   // true if this form was submitted by a user gesture and not javascript.
   bool user_submitted;
+
+  // Password form input fields.
+  FormFieldData username;
+  FormFieldData password;
+
+  // TODO (pritam.nikam): Make sure we remove |fields|, and add form fields

[vabr (Chromium), 2014/09/30 14:19:49]

The action described in TODO should be part of this CL. In other words, please
do not land without getting rid of |fields|.

[Pritam Nikam, 2014/10/13 10:48:00]

Seems, completely removing |fields| will take some time. As I go about
interpreting the  current logic, fields apart from username & password are
|AutofillField| type (derived from FormFieldData). And |fields| (an array of
FormFieldData) get distinguished/categorized on heuristic match performed on
browser side on receiving AutofillHostMsg_FormsSeen. (Ref: [2]).

So there are 2 approaches we can adopt:
1. Perform heuristic match on renderer side inside - WebFormElementToFormData()
Ref: [1] and fill the fields.
2. Pass FormFieldData array instead of bundling it in FormData, till it get
parsed on browser side and gets categorized based on heuristic (as per current
implementation).

For both of these approaches I could sense good amount of code changes :)

Any pointers to other possible way(s) to go about performing this cleanup will
help.


[1].
https://code.google.com/p/chromium/codesearch#chromium/src/components/autofil...

[2].
https://code.google.com/p/chromium/codesearch#chromium/src/components/autofil...

[Ilya Sherman, 2014/10/13 23:49:32]

It sounds like we're using this class both for Autofill and for Password
Autofill, which is causing some pain.  This class is primarily designed to be
used with Autofill code.  Perhaps the most appropriate change is to use separate
classes for Password Autofill vs. Autofill.

Indeed, there is already a PasswordFormFillData class.  Perhaps it would be
appropriate to add the fields to that class, rather than to the shared FormData
class.

+  // for all possible autofillable input fields.
+
   // A vector of all the input fields in the form.
   std::vector<FormFieldData> fields;
 };