[Password manager] Relplace the FormFieldData vector from autofill::FormData with named fields…

components/autofill/core/common/form_data.h

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef COMPONENTS_AUTOFILL_CORE_COMMON_FORM_DATA_H_
 #define COMPONENTS_AUTOFILL_CORE_COMMON_FORM_DATA_H_
 
 #include <vector>
 
 #include "base/strings/string16.h"
@@ skipping 17 matching lines @@
   bool operator<(const FormData& form) const;
 
   // The name of the form.
   base::string16 name;
   // The URL (minus query parameters) containing the form.
   GURL origin;
   // The action target of the form.
   GURL action;
   // true if this form was submitted by a user gesture and not javascript.
   bool user_submitted;
+
+  // Password form input fields.
+  FormFieldData username;
+  FormFieldData password;
+
+  // TODO (pritam.nikam): Make sure we remove |fields|, and add form fields

[vabr (Chromium), 2014/09/30 14:19:49]

The action described in TODO should be part of this CL. In other words, please
do not land without getting rid of |fields|.

[Pritam Nikam, 2014/10/13 10:48:00]

Seems, completely removing |fields| will take some time. As I go about
interpreting the  current logic, fields apart from username & password are
|AutofillField| type (derived from FormFieldData). And |fields| (an array of
FormFieldData) get distinguished/categorized on heuristic match performed on
browser side on receiving AutofillHostMsg_FormsSeen. (Ref: [2]).

So there are 2 approaches we can adopt:
1. Perform heuristic match on renderer side inside - WebFormElementToFormData()
Ref: [1] and fill the fields.
2. Pass FormFieldData array instead of bundling it in FormData, till it get
parsed on browser side and gets categorized based on heuristic (as per current
implementation).

For both of these approaches I could sense good amount of code changes :)

Any pointers to other possible way(s) to go about performing this cleanup will
help.


[1].
https://code.google.com/p/chromium/codesearch#chromium/src/components/autofil...

[2].
https://code.google.com/p/chromium/codesearch#chromium/src/components/autofil...

[Ilya Sherman, 2014/10/13 23:49:32]

It sounds like we're using this class both for Autofill and for Password
Autofill, which is causing some pain.  This class is primarily designed to be
used with Autofill code.  Perhaps the most appropriate change is to use separate
classes for Password Autofill vs. Autofill.

Indeed, there is already a PasswordFormFillData class.  Perhaps it would be
appropriate to add the fields to that class, rather than to the shared FormData
class.

+  // for all possible autofillable input fields.
+
   // A vector of all the input fields in the form.
   std::vector<FormFieldData> fields;
 };
 
 // For testing.
 std::ostream& operator<<(std::ostream& os, const FormData& form);
 
 // Serialize FormData. Used by the PasswordManager to persist FormData
 // pertaining to password forms. Serialized data is appended to |pickle|
 void SerializeFormData(const FormData& form_data, Pickle* pickle);
 // Deserialize FormData. This assumes that |iter| is currently pointing to
 // the part of a pickle created by SerializeFormData. Returns true on success.
 bool DeserializeFormData(PickleIterator* iter, FormData* form_data);
 
 }  // namespace autofill
 
 #endif  // COMPONENTS_AUTOFILL_CORE_COMMON_FORM_DATA_H_